util-linux: use systemdLibs, minor cleanup#439122
Merged
Merged
Conversation
vog
approved these changes
Sep 1, 2025
vog
left a comment
Contributor
There was a problem hiding this comment.
All 3 commits look fine to me!
Contributor
|
@drupol The changes themselves are fine! However:
|
e0f98b4 to
f217c9e
Compare
f217c9e to
64d3b1c
Compare
systemdLibssystemdLibs, minor cleanup
vog
approved these changes
Sep 1, 2025
vog
left a comment
Contributor
There was a problem hiding this comment.
Looks all very good to me! 👍
numinit
requested changes
Sep 1, 2025
Contributor
|
This is a good change! One thing consumers can always do is depend on |
13 tasks
617f654 to
8bf55ef
Compare
See TODO in NixOS#432567 for context Co-authored-by: Grimmauld <soeren@benjos.de>
32cb963 to
6fdf695
Compare
Contributor
|
Btw if you are interested in reducing the reverse closure of util-linux: The currently biggest consumers are qt6 |
Contributor
|
Looks good, I can still build up to util-linux. |
numinit
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was investigating why
systemdwas required in a Home Manager profile when I found out thatutil-linuxwas requiring it.This PR is a proposal, similar to #433641
Feel free to let me know what you think.
Here's the closure size after/before:
On top of that, this PR make a very minor cleanup in the
postInstallattribute, regrouping lines that are meant to be together, making it easier to read.Lastly, it also fixes the use of the
finalAttrspattern, there's no need to userecwhen using it.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.