Skip to content

bubblewrap: add dev output to fix static build#433640

Merged
wolfgangwalther merged 1 commit into
NixOS:stagingfrom
vog:bubblewrap-add-dev
Aug 17, 2025
Merged

bubblewrap: add dev output to fix static build#433640
wolfgangwalther merged 1 commit into
NixOS:stagingfrom
vog:bubblewrap-add-dev

Conversation

@vog

@vog vog commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Aug 14, 2025
@nix-owners nix-owners Bot requested a review from dotlambda August 14, 2025 11:55
@vog

vog commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

This reduces the closure size of pkgs.pkgsStatic.bubblewrap dramatically.

Before:

$ nix-store -qR /nix/store/shy641wv94cifwcvc3s0m4rckp1sv2sg-bubblewrap-static-x86_64-unknown-linux-musl-0.11.0
/nix/store/0hh4fq8kn7zsxdg0r7yxs0ljbyzghrg1-libselinux-static-x86_64-unknown-linux-musl-3.8.1-bin
/nix/store/0v1n2hbp33j87hlbnfxc1img26sis2jm-pcre2-static-x86_64-unknown-linux-musl-10.44
/nix/store/44dnsx0ig1ghhxiv3g3pilhghxss8nnj-bash-static-x86_64-unknown-linux-musl-5.2p37
/nix/store/5237l27x4d784ncx0kh1q66rl88ag74k-bash-completion-static-x86_64-unknown-linux-musl-2.16.0
/nix/store/ijbrwlxnxfpg2l2bnv57w245prgcr5h9-pcre2-static-x86_64-unknown-linux-musl-10.44-bin
/nix/store/5rsqahrh7skpnpmqqv63idadcnhqi0nw-pcre2-static-x86_64-unknown-linux-musl-10.44-dev
/nix/store/8mk5idamlydiwfffdxi0gavxw0af21ki-libsepol-static-x86_64-unknown-linux-musl-3.8.1
/nix/store/g9fkd8j29j0dmln6xinp3mk7qcpwfizz-tzdata-2025b
/nix/store/cdc7y6g5bmdyyxblrsqasdz9fa5p5ydj-libcap-static-x86_64-unknown-linux-musl-2.75
/nix/store/ginmqq46mkhhir7m1z3jxbhixr33jkb4-libsepol-static-x86_64-unknown-linux-musl-3.8.1-bin
/nix/store/ja32mayxml0b7k893ffvlay2vn64nkc9-libsepol-static-x86_64-unknown-linux-musl-3.8.1-dev
/nix/store/skmc2sr7z4p04v6lh2jm81fdvrk3xwwl-libselinux-static-x86_64-unknown-linux-musl-3.8.1
/nix/store/ygkdisg7zi2g1kakyw8fibrm6dlpz87p-musl-fts-static-x86_64-unknown-linux-musl-1.2.7
/nix/store/ldlqcam9xkgngnhg01cc3f4yqfkwajqi-libselinux-static-x86_64-unknown-linux-musl-3.8.1-dev
/nix/store/sj4qn13vglz5ynqq3df91gimib5z6llm-libcap-static-x86_64-unknown-linux-musl-2.75-lib
/nix/store/xpgb4nf4749p00x4mmj7zsbfr2g0rcbk-libcap-static-x86_64-unknown-linux-musl-2.75-dev
/nix/store/shy641wv94cifwcvc3s0m4rckp1sv2sg-bubblewrap-static-x86_64-unknown-linux-musl-0.11.0
$ nix-store -qR /nix/store/shy641wv94cifwcvc3s0m4rckp1sv2sg-bubblewrap-static-x86_64-unknown-linux-musl-0.11.0 | xargs tar c | wc -c
28723200

After:

$ nix-store -qR /nix/store/y61h0w7p9bgjisndx6dw9m00d3r0m41s-bubblewrap-static-x86_64-unknown-linux-musl-0.11.0
/nix/store/y61h0w7p9bgjisndx6dw9m00d3r0m41s-bubblewrap-static-x86_64-unknown-linux-musl-0.11.0
$ nix-store -qR /nix/store/y61h0w7p9bgjisndx6dw9m00d3r0m41s-bubblewrap-static-x86_64-unknown-linux-musl-0.11.0 | xargs tar c | wc -c
245760

So we have a reduction from 28 MiB to 240 KiB.

@vog

vog commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

Related: #433641.

@vog vog mentioned this pull request Aug 14, 2025
Merged
13 tasks
@wolfgangwalther

wolfgangwalther commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

Too many rebuilds - please target staging.

@vog vog force-pushed the bubblewrap-add-dev branch from f20ef0b to 0931102 Compare August 16, 2025 13:29
@vog vog changed the base branch from master to staging August 16, 2025 13:29
@nixpkgs-ci nixpkgs-ci Bot closed this Aug 16, 2025
@nixpkgs-ci nixpkgs-ci Bot reopened this Aug 16, 2025
@vog

vog commented Aug 16, 2025

Copy link
Copy Markdown
Contributor Author

Too many rebuilds - please target staging.

@wolfgangwalther Done.

@wolfgangwalther

wolfgangwalther commented Aug 17, 2025

Copy link
Copy Markdown
Contributor

This reduces the closure size of pkgs.pkgsStatic.bubblewrap dramatically.

The PR title says it "fixes" the static build, but this comment indicates that the static build worked before and this is just about a closure size change.

Could you clarify and adjust the commit message / PR title accordingly if that needs change?

@wolfgangwalther

wolfgangwalther commented Aug 17, 2025

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 433640 --package bubblewrap --package pkgsStatic.bubblewrap
Commit: 093110250434ab159312cf6b19d2edb0e720df1c

x86_64-linux

✅ 4 packages built:
  • bubblewrap
  • bubblewrap.dev (bubblewrap.dev.dev)
  • pkgsStatic.bubblewrap
  • pkgsStatic.bubblewrap.dev (pkgsStatic.bubblewrap.dev.dev)

aarch64-linux

✅ 4 packages built:
  • bubblewrap
  • bubblewrap.dev (bubblewrap.dev.dev)
  • pkgsStatic.bubblewrap
  • pkgsStatic.bubblewrap.dev (pkgsStatic.bubblewrap.dev.dev)

x86_64-darwin

⏩ 4 packages marked as broken and skipped:
  • bubblewrap
  • bubblewrap.dev
  • pkgsStatic.bubblewrap
  • pkgsStatic.bubblewrap.dev

aarch64-darwin

⏩ 4 packages marked as broken and skipped:
  • bubblewrap
  • bubblewrap.dev
  • pkgsStatic.bubblewrap
  • pkgsStatic.bubblewrap.dev

@wolfgangwalther wolfgangwalther merged commit f2b5d60 into NixOS:staging Aug 17, 2025
64 of 85 checks passed
@wolfgangwalther

wolfgangwalther commented Aug 17, 2025

Copy link
Copy Markdown
Contributor

The PR title says it "fixes" the static build, but this comment indicates that the static build worked before and this is just about a closure size change.

Could you clarify and adjust the commit message / PR title accordingly if that needs change?

I tested, and it built fine before. Thus I changed the commit message accordingly while squash merging the single commit.

nixpkgs-ci Bot pushed a commit that referenced this pull request Aug 17, 2025
@vog @github-actions
bubblewrap: add dev output to reduce closure size of static build (#4…
3cb4798 
…33640)

(cherry picked from commit f2b5d60)
@nixpkgs-ci

nixpkgs-ci Bot commented Aug 17, 2025

Copy link
Copy Markdown
Contributor

Successfully created backport PR for staging-25.05:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Aug 17, 2025
@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Aug 17, 2025
Merged
1 task
wolfgangwalther added a commit that referenced this pull request Aug 17, 2025
@wolfgangwalther @vog
[Backport staging-25.05] bubblewrap: add dev output to fix static bui…
7770c78 
…ld (#434455)

bubblewrap: add dev output to reduce closure size of static build (#433640)

(cherry picked from commit f2b5d60)

Co-authored-by: Volker Diels-Grabsch <v@njh.eu>
@vog vog deleted the bubblewrap-add-dev branch September 7, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes
@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vog @wolfgangwalther