workflows/eval: fix compare job not running#433043
Merged
Merged
Conversation
The conclusion of the `versions` job propagates from through `eval` to `compare`, which meant the `compare` job was skipped. No rebuild labels, no reviewer requests. Also, we don't want to run eval when `versions` runs, but fails.
nix-owners
Bot
requested review from
MattSturgeon,
Mic92,
philiptaron and
zowoq
nixpkgs-ci
Bot
added
6.topic: continuous integration
Contributor
Author
|
I confirmed this fixes regular PRs. We can also see that I didn't test the case with |
This comment was marked as resolved.
This comment was marked as resolved.
wolfgangwalther
added
the
8.has: port to stable
Contributor
Author
Tested this as well, worked in my test case. So should be good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conclusion of the
versionsjob propagates from throughevaltocompare, which meant thecomparejob was skipped. No rebuild labels, no reviewer requests.Also, we don't want to run eval when
versionsruns, but fails.This regressed in #427724. Fixes #427724 (comment).
Things done
Add a 👍 reaction to pull requests you find important.