Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maintainers/scripts/auto-rebase/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ for line in "${autoLines[@]}"; do
# commit is unchanged. This is why the following is also necessary:
# - The tree filter runs the command on each of our own commits,
# effectively reapplying it.
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch \
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch -f \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd prefer to use verbose CLI flags in script sources, as they add additional self-documenting context.

Suggested change
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch -f \
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch --force \

--parent-filter "sed 's/$parent/$autoCommit/'" \
--tree-filter "$autoCmd" \
"$autoCommit"..HEAD
Expand Down
Loading