holesail: init at 1.10.1 by jjacke13 · Pull Request #432474 · NixOS/nixpkgs

jjacke13 · 2025-08-10T09:21:55Z

Things done

Add a 👍 reaction to pull requests you find important.

yzx9 · 2025-08-10T09:51:02Z

Suggested change

rev = "refs/tags/${version}";

tag = finalAttrs.version;

yzx9 · 2025-08-10T09:53:11Z

Nit: Use finalAttrs is a good practice as it's override friendly

yzx9 · 2025-08-10T09:54:26Z

Suggested change

repo = pname;

repo = "holesail";

We should not use pname as that is wrong when changed. Please use the literal string.

yzx9 · 2025-08-10T09:58:02Z

Nit: Using with lib; in a large attrset is generally discouraged since it's ambiguity and leads to potential name collisions

yzx9 · 2025-08-10T10:01:42Z

Suggested change

description = "Peer-to-peer network tunneling and reverse proxy software.";

description = "Peer-to-peer network tunneling and reverse proxy software";

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#meta-attributes

yzx9 · 2025-08-10T10:05:44Z

Suggested change

];

];

mainProgram = "holesail";

jjacke13 · 2025-08-10T10:28:30Z

I updated the commit following your recommendations.

yzx9 · 2025-08-10T10:37:50Z

I got a different hash. Did something not get updated?

specified: sha256-eANDS4Avu6or+1XXRmM+rceZzjKchhoc5nbv1grpvwE=
got: sha256-7YTBwjU0xzoDqlRqfdQZrJRvSXTtT8rpA1zRdLSdFoU=

jjacke13 · 2025-08-10T10:45:36Z

I suppose this happened because now it doesn't fetch the zip file from the releases. I changed the hash as well as the npmdeps hash

yzx9 · 2025-08-10T10:53:25Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432474
Commit: a7f2aaadd6823e31b6f6ec2f0227af44b9998046

`x86_64-linux`

✅ 1 package built:

holesail

yzx9

LGTM. I noticed this package should also work on Darwin. I’m fine with either adding Darwin support or leaving it as is.

jjacke13 · 2025-08-10T11:01:33Z

The only reason that i didn't add darwin in the available platforms, is that i haven't checked if this build process works well on darwin. I can't check it myself because i don't own a Mac. I was thinking that we could add another maintainer at some point if anyone tries it on Mac. Also, i will notify the owner of holesail repo and ask them if they want to be added as maintainers

jjacke13 · 2025-08-10T11:06:38Z

In the future i am planning to start a PR with a NixosModule for holesail. I have already built it, but it needs some polishing.

jjacke13 · 2025-08-31T18:14:15Z

Friendly ping -
Is there anything else needed for merge?

jjacke13 · 2025-09-19T15:23:29Z

Friendly ping :)

GraysonTinker · 2026-04-08T16:15:47Z

Hey @jjacke13, thanks for working on this :). If you're still interested, would you be willing to bump the version? (Also noting there was a license change.) If you're willing, I'd also be happy to be a co-maintainer.

jjacke13 · 2026-04-13T10:11:14Z

Hey @jjacke13, thanks for working on this :). If you're still interested, would you be willing to bump the version? (Also noting there was a license change.) If you're willing, I'd also be happy to be a co-maintainer.

Yes! Thanks for your interest! I will do it in the next couple of days :)

jjacke13 · 2026-04-19T21:09:15Z

Bumped to 2.4.1 and updated the license to AGPL-3.0.

@GraysonTinker I'd be happy to add you as co-maintainer! You'll need to add yourself to maintainers/maintainer-list.nix first (via a separate PR). Once that's merged, I can add you here.

GraysonTinker · 2026-04-19T21:10:49Z

Bumped to 2.4.1 and updated the license to AGPL-3.0.

@GraysonTinker I'd be happy to add you as co-maintainer! You'll need to add yourself to maintainers/maintainer-list.nix first (via a separate PR). Once that's merged, I can add you here.

Thanks! I'm already listed; I think you'll need to rebase your branch.

jjacke13 · 2026-04-19T21:13:18Z

Added you as co-maintainer!

GraysonTinker

Seems like the checks are now failing because of a new requirement; should be fairly easy to resolve.

GraysonTinker · 2026-04-21T13:46:44Z

+  npmPackFlags = [ "--ignore-scripts" ];
+
+  dontNpmBuild = true;
+


Suggested change

__structuredAttrs = true;

buildNpmPackage currently doesn't support __structuredAttrs. The issue is that npmDeps and npmBuildScript are set as top-level derivation attributes (here), so with structured attrs they end up in NIX_ATTRS_SH_FILE as bash variables but aren't exported — meaning the prefetch-npm-deps Rust tool can't see them via env::var_os() and panics.

The fix would be in build-npm-package/default.nix:

Add excludeDrvArgNames = [ "npmDeps" "npmBuildScript" ]; to avoid conflicts

Move inherit npmDeps npmBuildScript; into the env attrset

I have this working locally — happy to include it as a separate commit in this PR, or as a prerequisite PR if preferred. Though I might be missing something here — let me know if you're aware of a simpler way to handle this!

Oh, sorry for missing that. After looking around a bit I think a fix has already been merged to staging in #487974, and will be merged to master in #507470. I'm not sure what the timeline for that PR to get merged would be but I suspect it will be in the near future. (If I cherry-pick that commit it works.) For now I think there's nothing to do but wait -- thanks for sticking through this.

Timeline: very soon now.

GraysonTinker · 2026-04-21T13:48:09Z

+
+  npmPackFlags = [ "--ignore-scripts" ];
+
+  dontNpmBuild = true;


Just noting that it seems like there could be a possibility of building to a native binary with the upstream scripts now. But that doesn't have to be done right now, maybe I'll take a crack at it in a follow-up.

i 've been working on a C++ implementation of the underlying protocol (HyperDHT). It is working pretty well and in the short future we can have holesail written in any language we like ;) so single binary will be trivial ;)

GraysonTinker · 2026-05-03T22:24:58Z

@jjacke13 Just in case you didn't know, those changes are now merged and this can be updated.

jjacke13 · 2026-05-04T15:45:50Z

Rebased on latest master and added __structuredAttrs = true;. Thanks for the heads-up @GraysonTinker!

GraysonTinker · 2026-05-05T16:08:54Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432474
Commit: 4558d071c02119d7eab1e8571f432e7a7cc2eb8d

`x86_64-linux`

✅ 1 package built:

holesail

GraysonTinker

Tested and seems like it's working good.

nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 10, 2025

jjacke13 force-pushed the master branch 2 times, most recently from 3a79a4a to 0c9c6e4 Compare August 10, 2025 09:44

nixpkgs-ci Bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 10, 2025

yzx9 reviewed Aug 10, 2025

View reviewed changes

nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 10, 2025

jjacke13 force-pushed the master branch from 0c9c6e4 to 84770a2 Compare August 10, 2025 10:26

jjacke13 force-pushed the master branch from 84770a2 to a7f2aaa Compare August 10, 2025 10:43

yzx9 approved these changes Aug 10, 2025

View reviewed changes

nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 10, 2025

yzx9 added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 1, 2025

nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 1, 2025

nixpkgs-ci Bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2026

nixpkgs-ci Bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 8, 2026

jjacke13 force-pushed the master branch from a7f2aaa to 8bfc140 Compare April 19, 2026 21:07

jjacke13 force-pushed the master branch from 8bfc140 to 239d966 Compare April 19, 2026 21:12

nixpkgs-ci Bot added the 8.has: package (new) This PR adds a new package label Apr 19, 2026

GraysonTinker reviewed Apr 21, 2026

View reviewed changes

holesail: init at 2.4.1

4558d07

jjacke13 force-pushed the master branch from 239d966 to 4558d07 Compare May 4, 2026 15:45

GraysonTinker approved these changes May 5, 2026

View reviewed changes

nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 5, 2026

	description = "Peer-to-peer network tunneling and reverse proxy software.";
	description = "Peer-to-peer network tunneling and reverse proxy software";

Uh oh!

Uh oh!

Conversation

jjacke13 commented Aug 10, 2025

Things done

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yzx9 Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjacke13 commented Aug 10, 2025

Uh oh!

yzx9 commented Aug 10, 2025

Uh oh!

jjacke13 commented Aug 10, 2025

Uh oh!

yzx9 commented Aug 10, 2025

nixpkgs-review result

x86_64-linux

Uh oh!

yzx9 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjacke13 commented Aug 10, 2025

Uh oh!

jjacke13 commented Aug 10, 2025

Uh oh!

jjacke13 commented Aug 31, 2025

Uh oh!

jjacke13 commented Sep 19, 2025

Uh oh!

GraysonTinker commented Apr 8, 2026

Uh oh!

jjacke13 commented Apr 13, 2026

Uh oh!

jjacke13 commented Apr 19, 2026

Uh oh!

GraysonTinker commented Apr 19, 2026

Uh oh!

jjacke13 commented Apr 19, 2026

Uh oh!

GraysonTinker left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GraysonTinker commented May 3, 2026

Uh oh!

jjacke13 commented May 4, 2026

Uh oh!

GraysonTinker commented May 5, 2026

nixpkgs-review result

x86_64-linux

Uh oh!

GraysonTinker left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

yzx9 Aug 10, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

yzx9 left a comment •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`