Skip to content

Contributor documentation for Modular Services#431396

Merged
roberth merged 2 commits into
NixOS:masterfrom
roberth:doc-review-modular-services
Aug 19, 2025
Merged

Contributor documentation for Modular Services#431396
roberth merged 2 commits into
NixOS:masterfrom
roberth:doc-review-modular-services

Conversation

@roberth

@roberth roberth commented Aug 6, 2025

Copy link
Copy Markdown
Member
  1. Anyone should be able to review this new kind of module
  2. Modular Services is a new feature for an unmerged RFC: manage expectations and avoid imposing any undue load on maintainers; try to help them instead

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@roberth roberth requested review from aanderse and infinisil August 6, 2025 09:14
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels Aug 6, 2025
@aanderse

aanderse commented Aug 7, 2025

Copy link
Copy Markdown
Member

i like the content of this, it is nice and consistent with the discussion in #430490, manages expectations of all potentially involved parties 👍

thanks for doing this @roberth ❤️

@roberth roberth force-pushed the doc-review-modular-services branch from f87abab to 0b4516a Compare August 8, 2025 22:28
@roberth roberth force-pushed the doc-review-modular-services branch from 0b4516a to 0b9a1cb Compare August 8, 2025 22:33
@roberth roberth merged commit ce7fefb into NixOS:master Aug 19, 2025
26 of 27 checks passed
@roberth roberth mentioned this pull request Aug 19, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants