Skip to content

redis: skip replication-rdbchannel test#422377

Closed
ungeskriptet wants to merge 1 commit into
NixOS:masterfrom
ungeskriptet:fix-redis
Closed

redis: skip replication-rdbchannel test#422377
ungeskriptet wants to merge 1 commit into
NixOS:masterfrom
ungeskriptet:fix-redis

Conversation

@ungeskriptet

Copy link
Copy Markdown
Member

This commit fixes compiling redis on the Raspberry Pi 5 (see attached logs).

redis.txt

Cc: @Saterfield990 @berdario @globin @LeSuisse @magistau @fabianhjr

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

This fixes the following error:
Test replica recovers connection failures in tests/integration/replication-rdbchannel.tcl
@nix-owners nix-owners Bot requested a review from globin July 4, 2025 10:47
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 12.first-time contribution This PR is the author's first one; please be gentle! labels Jul 4, 2025
@acid-bong

Copy link
Copy Markdown
Contributor

Why not hide behind lib.optionalString stdenv.hostPlatform.isAarch64? The test doesn't fail on amd64

@ungeskriptet

ungeskriptet commented Jul 4, 2025

Copy link
Copy Markdown
Member Author

Duplicate, closing due to #422352

@ungeskriptet ungeskriptet deleted the fix-redis branch July 29, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants