py-wacz: init at 0.5.0#420437
Merged
Merged
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
applePrincess
suggested changes
Jun 27, 2025
Member
Author
|
Thanks for the review! I've dug a bit deeper and cleaned up more unnecessary dependencies (see comments). |
Contributor
|
Member
Author
|
Fixed It happens to work in the 3.13 case since those packages are implicitly added to the |
Contributor
|
applePrincess
approved these changes
Jun 28, 2025
nixpkgs-ci
Bot
added
the
12.approvals: 1
doronbehar
reviewed
Jul 1, 2025
doronbehar
left a comment
doronbehar
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good! Just a few notes and this should be good to go.
zhaofengli
commented
Jul 2, 2025
The Python module is named wacz. Signing isn't enabled yet.
Contributor
|
doronbehar
previously approved these changes
Jul 7, 2025
doronbehar
dismissed
their stale review
July 7, 2025 05:51
Haven't checked binaries in nixpkgs-review.
Contributor
|
Error from |
Contributor
|
Similar error from |
Contributor
|
And many SyntaxWarnings from |
doronbehar
requested changes
Jul 7, 2025
doronbehar
left a comment
doronbehar
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your work so far @zhaofengli . Please fix the issues just commented about.
Member
Author
|
Hmm, I can't reproduce the failure (either My output (after merging nixos-unstable)$ /nix/store/fm8z6yq209yy8af7f5jbhk530y401w0p-python3.13-wacz-0.5.0/bin/wacz --help
usage: wacz [-h] [-V] {create,validate} ...
WACZ creator
positional arguments:
{create,validate}
create create wacz file
validate validate a wacz file
options:
-h, --help show this help message and exit
-V, --version show program's version number and exit |
doronbehar
approved these changes
Jul 8, 2025
Contributor
|
Indeed this is very peculiar... I now went to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WACZ is a format for web archives. It combines regular WARC data with indexes to enable efficient random access of archives (e.g., https://replayweb.page).
py-waczprovides thewaczcommand to create and validate WACZ archives. WARC archives generated by other tools can be ingested to create indexed WACZs. Some platforms (such as Browsertrix Cloud) also provide authenticated WACZ archives with digital signatures. The signature validation feature is not enabled in this PR.It's best to review this PR commit-by-commit.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.