OCaml: default to version 5.3#397478
Merged
Merged
Conversation
github-actions
Bot
added
the
6.topic: ocaml
47 tasks
github-actions
Bot
added
10.rebuild-darwin: 101-500
Contributor
|
Format check is failing |
Contributor
Author
If you have some spare time, you can file a bug report against |
Contributor
|
Please apply nixfmt-rfc-style in its current version. The entire tree has been formatted and we should consider a failing check to be actionable here. An issue in its output is not justification for ignoring the check, and you’d be leaving this problem for the next user or the next treewide format. I understand you may not like how this is being formatted, it may even be a bug upstream, but in the end these are mostly nits that the standardization is intended to remove. |
Contributor
Author
|
You might be right. But this is certainly not the place to discuss this issue. |
Contributor
|
We're discussing it here because of the failing check. Will you apply the formatter to fix that failing check? |
Contributor
Author
|
No. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
adamcstephens
previously requested changes
Apr 10, 2025
adamcstephens
left a comment
adamcstephens
left a comment
Contributor
There was a problem hiding this comment.
Formatting is no longer optional and failing to do so can cause failures for other PRs. This is true since the treewide format and enforcement PR. #380990.
Please see the approved and adopted RFC https://github.com/NixOS/rfcs/blob/master/rfcs/0166-nix-formatting.md
If you don’t like the output one suggestion could be to use this instead
assert lib.throwIf (lib.versionAtLeast ocaml.version "5.3") "eliom is not available for OCaml ${ocaml.version}" true;
Member
This not a bug. Nixfmt is not reponsible for making every Nixpkgs idiosyncracy look good, and either way it has no means of doing that without resorting to static code analysis |
Contributor
|
adamcstephens
approved these changes
Apr 18, 2025
adamcstephens
left a comment
adamcstephens
left a comment
Contributor
There was a problem hiding this comment.
All the failures are already happening on master. diffoscope was the only odd one out, but a check of its build yielded the same failure on master.
Contributor
|
Thanks for the update. Sorry if it's not ideal. :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.