Skip to content

Adding mtime=0 to arandr to improve deterministic build#395218

Closed
TessyJames28 wants to merge 2 commits into
NixOS:masterfrom
TessyJames28:arandr-nondeterminism-fix
Closed

Adding mtime=0 to arandr to improve deterministic build#395218
TessyJames28 wants to merge 2 commits into
NixOS:masterfrom
TessyJames28:arandr-nondeterminism-fix

Conversation

@TessyJames28

@TessyJames28 TessyJames28 commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 1, 2025
@nix-owners nix-owners Bot requested a review from gepbird April 1, 2025 16:19
@gepbird

gepbird commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Hi @TessyJames28, I see this fixed the reproducibility issue related to #383869, thanks for your work!

What's the reason for closing this?

@TessyJames28

Copy link
Copy Markdown
Contributor Author

I noticed it was failing one of the check because of formatting issue. I have to address the issue. I have made another pull request

@gepbird

gepbird commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

You can rebase with git and force push to an existing PR, but creating a new one is fine too.

Also note that a big formatting PR was recently merged, if you still have issues with it try pulling the latest master branch and create a new branch from there (or rebase your existing branch on top of it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants