Adding mtime=0 to arandr to improve deterministic build#395218
Closed
TessyJames28 wants to merge 2 commits into
Closed
Adding mtime=0 to arandr to improve deterministic build#395218TessyJames28 wants to merge 2 commits into
TessyJames28 wants to merge 2 commits into
Conversation
Contributor
|
Hi @TessyJames28, I see this fixed the reproducibility issue related to #383869, thanks for your work! What's the reason for closing this? |
Contributor
Author
|
I noticed it was failing one of the check because of formatting issue. I have to address the issue. I have made another pull request |
Contributor
|
You can rebase with git and force push to an existing PR, but creating a new one is fine too. Also note that a big formatting PR was recently merged, if you still have issues with it try pulling the latest master branch and create a new branch from there (or rebase your existing branch on top of it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.