Skip to content

tsm-client: 8.1.25.0 -> 8.1.27.0, drop old migration code#387363

Merged
doronbehar merged 3 commits into
NixOS:masterfrom
Yarny0:tsm-vmtest-and-freeform-migration
Jul 16, 2025
Merged

tsm-client: 8.1.25.0 -> 8.1.27.0, drop old migration code#387363
doronbehar merged 3 commits into
NixOS:masterfrom
Yarny0:tsm-vmtest-and-freeform-migration

Conversation

@Yarny0

@Yarny0 Yarny0 commented Mar 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" tries to rebuild 3000+ package and was therefore skipped.

Edit 2025-03-31 & Edit 2025-06-21: More:

  • Both test derivations (cli and gui) build/pass.
  • Successfully tested with a real tsm-server: uploaded some files for backup without errors/problems.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 5, 2025
@nixos-discourse

nixos-discourse commented Mar 16, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5289

@nixos-discourse

nixos-discourse commented Mar 27, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5323

@Yarny0 Yarny0 force-pushed the tsm-vmtest-and-freeform-migration branch from 568e50e to fbaf958 Compare March 31, 2025 16:38
@Yarny0 Yarny0 changed the title tsm-client: use runTest, drop old migration code from module tsm-client: update, use runTest, drop old migration code from module Mar 31, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@Yarny0 Yarny0 force-pushed the tsm-vmtest-and-freeform-migration branch from fbaf958 to 019e478 Compare April 2, 2025 17:20
@ofborg ofborg Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@Yarny0

Yarny0 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor Author

Pushed a rebase due to #380990

@nixos-discourse

nixos-discourse commented Apr 7, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5361

@nixos-discourse

nixos-discourse commented Apr 18, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5396

lluchs
lluchs approved these changes Apr 21, 2025
View reviewed changes

@lluchs lluchs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package builds and the test runs correctly on my machine.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 22, 2025
@nixos-discourse

nixos-discourse commented May 2, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5439

@nixos-discourse

nixos-discourse commented May 13, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5472

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 14, 2025
@nixos-discourse

nixos-discourse commented May 25, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5500

@Yarny0 Yarny0 force-pushed the tsm-vmtest-and-freeform-migration branch from 019e478 to 31e8437 Compare May 29, 2025 07:56
@Yarny0 Yarny0 changed the title tsm-client: update, use runTest, drop old migration code from module tsm-client: 8.1.25.0 -> 8.1.26.0, ~~use runTest,~~ drop old migration code May 29, 2025
@Yarny0 Yarny0 changed the title tsm-client: 8.1.25.0 -> 8.1.26.0, ~~use runTest,~~ drop old migration code tsm-client: 8.1.25.0 -> 8.1.26.0, drop old migration code May 29, 2025
@github-actions github-actions Bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label May 29, 2025
@Yarny0

Yarny0 commented May 29, 2025

Copy link
Copy Markdown
Contributor Author

Branch updated and rebased to consider #410569 (which re-did the original intent of the pull-request at hand): The vmtest commit is no longer needed and dropped.

@nixos-discourse

nixos-discourse commented Jun 5, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5544

@nixos-discourse

nixos-discourse commented Jun 16, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5580

@Yarny0
nixos/tsm-client: drop migration code from 2023 freeform update
c9ebaf5 
This manually reverts
20a9a21.
Automatic revert is not possible due to nixfmt in
4f0dadb.
@Yarny0 Yarny0 force-pushed the tsm-vmtest-and-freeform-migration branch from 31e8437 to f9cc9bf Compare June 21, 2025 11:03
@Yarny0 Yarny0 changed the title tsm-client: 8.1.25.0 -> 8.1.26.0, drop old migration code tsm-client: 8.1.25.0 -> 8.1.27.0, drop old migration code Jun 21, 2025
@nixos-discourse

nixos-discourse commented Jun 27, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5616

@nixos-discourse

nixos-discourse commented Jul 14, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/115

@doronbehar

doronbehar commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

I'm not familiar with the changes in the 1st commit, but it doesn't look too bad, so I'll take the risk and merge this :).

@doronbehar doronbehar merged commit 2f83e9c into NixOS:master Jul 16, 2025
28 of 29 checks passed
@Yarny0 Yarny0 deleted the tsm-vmtest-and-freeform-migration branch July 17, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@lluchs lluchs lluchs approved these changes
@Luflosi Luflosi Luflosi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Yarny0 @nixos-discourse @doronbehar @lluchs @Luflosi @wegank