Skip to content

python313Packages.polyfactory: 2.18.1-unstable-2024-12-22 -> 2.19.0#380528

Merged
GaetanLepage merged 2 commits into
NixOS:masterfrom
Bot-wxt1221:polyfactory
Feb 18, 2025
Merged

python313Packages.polyfactory: 2.18.1-unstable-2024-12-22 -> 2.19.0#380528
GaetanLepage merged 2 commits into
NixOS:masterfrom
Bot-wxt1221:polyfactory

Conversation

@Bot-wxt1221

@Bot-wxt1221 Bot-wxt1221 commented Feb 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 9, 2025
@momeemt

momeemt commented Feb 9, 2025

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380528

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • chatgpt-retrieval-plugin
  • chatgpt-retrieval-plugin.dist
❌ 4 packages failed to build:
  • python312Packages.weaviate-client
  • python312Packages.weaviate-client.dist
  • python313Packages.weaviate-client
  • python313Packages.weaviate-client.dist
✅ 6 packages built:
  • litestar
  • litestar.dist
  • python312Packages.polyfactory
  • python312Packages.polyfactory.dist
  • python313Packages.polyfactory
  • python313Packages.polyfactory.dist

@momeemt

momeemt commented Feb 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

It failed to build in my aarch64-darwin env.

log 
$ nix build --file /nix/store/0b0h43qjabvb5f55fscwf20kq90air95-nixpkgs-review-3.0.0/lib/python3.12/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path 'nixpkgs=/Users/momeemt/.cache/nixpkgs-review/pr-38052
8/nixpkgs nixpkgs-overlays=/var/folders/09/9ttjqns51hx4cl_3c96llt_r0000gp/T/tmpkif_955d' --extra-experimental-features 'nix-command no-url-literals' --no-link --keep-going --no-allow-import-from-derivation --argstr
 local-system aarch64-darwin --argstr nixpkgs-path /Users/momeemt/.cache/nixpkgs-review/pr-380528/nixpkgs --argstr nixpkgs-config-path /var/folders/09/9ttjqns51hx4cl_3c96llt_r0000gp/T/tmper7c2zzv.nix --argstr attrs
-path /Users/momeemt/.cache/nixpkgs-review/pr-380528/attrs.nix
error: builder for '/nix/store/k45zscwapik0x35yzqdnb3amin3yhg64-python3.13-weaviate-client-4.10.4.drv' failed with exit code 1;
       last 10 log lines:
       > * Getting build dependencies for wheel...
       >
       > Traceback (most recent call last):
       >   File "/nix/store/3079564lbv43j8qdmzz263ygzmlnl1zh-python3.13-pyproject-hooks-1.2.0/lib/python3.13/site-packages/pyproject_hooks/_impl.py", line 402, in _call_hook
       >     raise BackendUnavailable(
       >     ...<4 lines>...
       >     )
       > pyproject_hooks._impl.BackendUnavailable: Cannot import 'setuptools.build_meta'
       >
       > ERROR Backend 'setuptools.build_meta' is not available.
       For full logs, run 'nix-store -l /nix/store/k45zscwapik0x35yzqdnb3amin3yhg64-python3.13-weaviate-client-4.10.4.drv'.
error: builder for '/nix/store/cdzs316y5ifz55p0dmz4rsrr9ab6an0a-python3.12-weaviate-client-4.10.4.drv' failed with exit code 1;
       last 10 log lines:
       > ERROR mock_tests/test_collection.py::test_node_with_timeout[verbose] - SystemExit: 1
       > ERROR mock_tests/test_collection.py::test_backup_cancel_while_create_and_restore - SystemExit: 1
       > ERROR mock_tests/test_collection.py::test_grpc_retry_logic - SystemExit: 1
       > ERROR mock_tests/test_collection.py::test_grpc_forbidden_exception - SystemExit: 1
       > ERROR mock_tests/test_tenants_get.py::test_tenants_get - SystemExit: 1
       > ERROR mock_tests/test_timeouts.py::test_timeout_rest_query - SystemExit: 1
       > ERROR mock_tests/test_timeouts.py::test_timeout_rest_insert - SystemExit: 1
       > ERROR mock_tests/test_timeouts.py::test_timeout_grpc_query - SystemExit: 1
       > ERROR mock_tests/test_timeouts.py::test_timeout_grpc_insert - SystemExit: 1
       > ===== 214 passed, 1 skipped, 5 deselected, 15 warnings, 34 errors in 4.55s =====
       For full logs, run 'nix-store -l /nix/store/cdzs316y5ifz55p0dmz4rsrr9ab6an0a-python3.12-weaviate-client-4.10.4.drv'.
error: 2 dependencies of derivation '/nix/store/67sfn51p2a3w17n7rq63ykpcny11ivc0-review-shell.drv' failed to build

@Bot-wxt1221

Bot-wxt1221 commented Feb 10, 2025

Copy link
Copy Markdown
Member Author

@momeemt #374977

@pbsds

pbsds commented Feb 17, 2025

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380528

x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • chatgpt-retrieval-plugin
  • chatgpt-retrieval-plugin.dist
✅ 10 packages built:
  • litestar
  • litestar.dist
  • python312Packages.polyfactory
  • python312Packages.polyfactory.dist
  • python312Packages.weaviate-client
  • python312Packages.weaviate-client.dist
  • python313Packages.polyfactory
  • python313Packages.polyfactory.dist
  • python313Packages.weaviate-client
  • python313Packages.weaviate-client.dist

aarch64-linux

⏩ 2 packages marked as broken and skipped:
  • chatgpt-retrieval-plugin
  • chatgpt-retrieval-plugin.dist
✅ 10 packages built:
  • litestar
  • litestar.dist
  • python312Packages.polyfactory
  • python312Packages.polyfactory.dist
  • python312Packages.weaviate-client
  • python312Packages.weaviate-client.dist
  • python313Packages.polyfactory
  • python313Packages.polyfactory.dist
  • python313Packages.weaviate-client
  • python313Packages.weaviate-client.dist

x86_64-darwin

⏩ 2 packages marked as broken and skipped:
  • chatgpt-retrieval-plugin
  • chatgpt-retrieval-plugin.dist
❌ 4 packages failed to build:
  • python312Packages.weaviate-client
  • python312Packages.weaviate-client.dist
  • python313Packages.weaviate-client
  • python313Packages.weaviate-client.dist
✅ 6 packages built:
  • litestar
  • litestar.dist
  • python312Packages.polyfactory
  • python312Packages.polyfactory.dist
  • python313Packages.polyfactory
  • python313Packages.polyfactory.dist

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • chatgpt-retrieval-plugin
  • chatgpt-retrieval-plugin.dist
❌ 4 packages failed to build:
  • python312Packages.weaviate-client
  • python312Packages.weaviate-client.dist
  • python313Packages.weaviate-client
  • python313Packages.weaviate-client.dist
✅ 6 packages built:
  • litestar
  • litestar.dist
  • python312Packages.polyfactory
  • python312Packages.polyfactory.dist
  • python313Packages.polyfactory
  • python313Packages.polyfactory.dist

@pbsds pbsds requested a review from happysalada February 17, 2025 01:20
@Bot-wxt1221

Bot-wxt1221 commented Feb 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

I have no interest on fixing weaviate-client on darwin.

@Bot-wxt1221 Bot-wxt1221 requested a review from a team February 17, 2025 01:32
@happysalada

happysalada commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

This looks good to me, could you mark it broken on darwin and then someone interested can fix it if they want

@Bot-wxt1221

Bot-wxt1221 commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

@happysalada Done.

@Bot-wxt1221 Bot-wxt1221 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 17, 2025
GaetanLepage
GaetanLepage reviewed Feb 17, 2025
View reviewed changes
Comment thread pkgs/development/python-modules/weaviate-client/default.nix Outdated
Comment thread pkgs/development/python-modules/weaviate-client/default.nix Outdated
@Bot-wxt1221 Bot-wxt1221 force-pushed the polyfactory branch 2 times, most recently from 9b7239f to 2834a02 Compare February 17, 2025 13:40
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 17, 2025
GaetanLepage
GaetanLepage reviewed Feb 17, 2025
View reviewed changes
Comment thread pkgs/development/python-modules/weaviate-client/default.nix Outdated
@GaetanLepage

GaetanLepage commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380528

x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • chatgpt-retrieval-plugin
  • chatgpt-retrieval-plugin.dist
✅ 12 packages built:
  • litestar (python312Packages.litestar)
  • litestar.dist (python312Packages.litestar.dist)
  • python312Packages.polyfactory
  • python312Packages.polyfactory.dist
  • python312Packages.weaviate-client
  • python312Packages.weaviate-client.dist
  • python313Packages.litestar
  • python313Packages.litestar.dist
  • python313Packages.polyfactory
  • python313Packages.polyfactory.dist
  • python313Packages.weaviate-client
  • python313Packages.weaviate-client.dist

aarch64-linux

⏩ 2 packages marked as broken and skipped:
  • chatgpt-retrieval-plugin
  • chatgpt-retrieval-plugin.dist
✅ 12 packages built:
  • litestar (python312Packages.litestar)
  • litestar.dist (python312Packages.litestar.dist)
  • python312Packages.polyfactory
  • python312Packages.polyfactory.dist
  • python312Packages.weaviate-client
  • python312Packages.weaviate-client.dist
  • python313Packages.litestar
  • python313Packages.litestar.dist
  • python313Packages.polyfactory
  • python313Packages.polyfactory.dist
  • python313Packages.weaviate-client
  • python313Packages.weaviate-client.dist

x86_64-darwin

✅ 8 packages built:
  • litestar (python312Packages.litestar)
  • litestar.dist (python312Packages.litestar.dist)
  • python312Packages.polyfactory
  • python312Packages.polyfactory.dist
  • python313Packages.litestar
  • python313Packages.litestar.dist
  • python313Packages.polyfactory
  • python313Packages.polyfactory.dist

aarch64-darwin

✅ 8 packages built:
  • litestar (python312Packages.litestar)
  • litestar.dist (python312Packages.litestar.dist)
  • python312Packages.polyfactory
  • python312Packages.polyfactory.dist
  • python313Packages.litestar
  • python313Packages.litestar.dist
  • python313Packages.polyfactory
  • python313Packages.polyfactory.dist

@GaetanLepage GaetanLepage merged commit 47703ed into NixOS:master Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes
@happysalada happysalada Awaiting requested review from happysalada
@pbsds pbsds Awaiting requested review from pbsds
@ethancedwards8 ethancedwards8 Awaiting requested review from ethancedwards8

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Bot-wxt1221 @momeemt @pbsds @happysalada @GaetanLepage @ethancedwards8 @wegank