Skip to content

zigbee2mqtt_2: init at 2.1.1#371053

Merged
mweinelt merged 2 commits into
NixOS:masterfrom
mweinelt:z2m-2.0
Feb 25, 2025
Merged

zigbee2mqtt_2: init at 2.1.1#371053
mweinelt merged 2 commits into
NixOS:masterfrom
mweinelt:z2m-2.0

Conversation

@mweinelt

@mweinelt mweinelt commented Jan 5, 2025

Copy link
Copy Markdown
Member

https://github.com/Koenkk/zigbee2mqtt/releases/tag/2.0.0

Not quite sure yet, if we should make the jump at 2.0.0 or wait a few versions.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 5, 2025
@nix-owners nix-owners Bot requested a review from sweber83 January 5, 2025 03:56
Comment thread pkgs/by-name/zi/zigbee2mqtt/package.nix Outdated
@teto

teto commented Jan 6, 2025

Copy link
Copy Markdown
Member

Not quite sure yet, if we should make the jump at 2.0.0 or wait a few versions.

what do you think of proposing both until before release ? I am tempted to test this this week but even then other people might want to remain at 1.42 for a while

@lucasew

This comment was marked as spam.

@mweinelt

mweinelt commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

Yeah, we can do that, unless the module requires further changes between the two versions.

@ofborg ofborg Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 3, 2025
@ofborg ofborg Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 21, 2025
@mweinelt

Copy link
Copy Markdown
Member Author

@teto PTAL.

@mweinelt mweinelt changed the title zigbee2mqtt: 1.42.0 -> 2.0.0 zigbee2mqtt_2: init at 2.1.1 Feb 21, 2025
Comment thread pkgs/by-name/zi/zigbee2mqtt_1/package.nix
@teto

teto commented Feb 24, 2025

Copy link
Copy Markdown
Member

I dont think I can test z2m 2 anytime soon but itshould not be required as long the default version is not changed.
The recommandation to deal with multiple versions of the same packages recommands to do things differently than what is done here:
https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#recommendation-for-new-packages-with-multiple-versions

@mweinelt

Copy link
Copy Markdown
Member Author

The seems like pointless gymnastics to make CI happy when callPackaging from all-packages.nix.

@mweinelt mweinelt merged commit 35f9b4c into NixOS:master Feb 25, 2025
@mweinelt mweinelt deleted the z2m-2.0 branch February 25, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants