goverlay: 0.7.1 -> 1.2

[Chais]

• Updated GOverlay from 0.7.1 to 1.2
  • Dropped unnecessary patches
  • Added new ones
  • Changelogs for versions 0.8.1 upwards can be viewed here. Older changelogs seem to be lost to issues with account access.
• Resolves Package request: Goverlay 0.7.1 -> 1.2 #335978
• Depends on libqt5pas,lazarus-qt: 3.2-0 -> 3.6-0, init Qt6 variants #368201 for lazarus-qt6 and libqt6pas

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[SigmaSquadron]

Welcome to Nixpkgs! Please review the Contribution Guidelines for more information about how to format your commits. Notably, their titles should follow the packagename: oldversion -> newversion template. Ideally, the removal of find-xdg-data-files and the alphabetical sorting should also be separate commits, following the packagename: change description template.

[SigmaSquadron]

For consistency with other packages, please put lib as the first attribute in the function call, followed by stdenv and fetchFromGitHub.

[Chais]

The sorting I can split out, I'm not sure how useful the removal of find-xdg-data-files is on its own. It was required with 0.7.1 but isn't with 1.2. Unless you're referring of the deletion of find-xdg-data-files.patch, than I can easily separate.

[SigmaSquadron]

Looks good to me! The commits have been named appropriately and the diff looks alright. I'll wait until the other PR is merged before running a build.

[kira-bruneau]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368202

---

x86_64-linux

⏩ 2 packages blacklisted:

• nixos-install-tools
• tests.nixos-functions.nixos-test

✅ 2 packages built:

• goverlay
• goverlay.man

[kira-bruneau]

Thanks for the update @Chais!!

Just for reference, I was originally getting a build error:

EThread: Failed to create new thread
  $0000000000444A56
  $0000000000444E71
  $0000000000937974
  $0000000000935AD8
  $000000000052F9BA
  $00000000005AAB8B
  $00000000004056F6
  $00000000004051E3
  $000000000040343F
  $0000000000408CE3
  $000000000040B9C9

This was one of the reasons why I removed myself as maintainer on goverlay, but finally tracked the issue down to a bug in lazarus: https://bugs.gentoo.org/937421.

I just had this option set in my NixOS config:

nix.daemonCPUSchedPolicy = "idle"

Temporarily removing this allows me to build the package again.

[kira-bruneau]

Oh wait, I missed that CI is failing on formatting right now. Other than that though, this looks good to me!

[Chais]

Oh wait, I missed that CI is failing on formatting right now. Other than that though, this looks good to me!

@kira-bruneau I saw the formatting check failing but was unsure if it's something that should be remedied, given that nixfmt mostly pulls arrays into fewer lines and most files have one element per line.

[kira-bruneau]

@kira-bruneau I saw the formatting check failing but was unsure if it's something that should be remedied, given that nixfmt mostly pulls arrays into fewer lines and most files have one element per line.

Oh yep it should be remedied here. It's not complete yet, but there's been a big push to have everything formatted with nixfmt. There are still some files that haven't been formatted yet, but that's mainly to avoid merge conflicts.

See #322537

[Chais]

nixfmt check still fails after running it. Would be helpful to know what the check takes offense at.

[kira-bruneau]

Oh I just ran it locally and pushed the diff. It looks like the issue was just an extra empty line.

[Chais]

Oh I just ran it locally and pushed the diff. It looks like the issue was just an extra empty line.

Oh, that's interesting. Yours arranged the arrays in one element per line again. What was it originally complaining about then?

[kira-bruneau]

Oh it was just the extra blank line above stdenv.mkDerivation that was left after removing find-xdg-data-files.