Skip to content

authentik: flag with knownVulnerabilities - #361567

Merged
Aleksanaa merged 1 commit into
NixOS:masterfrom
LeSuisse:authentik-flag-known-vulnerabilities
Dec 4, 2024
Merged

authentik: flag with knownVulnerabilities#361567
Aleksanaa merged 1 commit into
NixOS:masterfrom
LeSuisse:authentik-flag-known-vulnerabilities

Conversation

@LeSuisse

@LeSuisse LeSuisse commented Dec 3, 2024

Copy link
Copy Markdown
Member

The bump to 2024.10.x is currently stalled in #345940.

The fix for CVE-2024-52289 involves a backward incompatible API and DB change so it is also not great for a backport even if we cherry-picks the security fixes.

Given no NixOS module is available in nixpkgs marking the package with knownVulnerabilities should have a limited impact.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The bump to 2024.10.x is currently stalled in NixOS#345940.

The fix for CVE-2024-52289 involves a backward incompatible
API and DB change so it is also not great for a backport even
if we cherry-picks the security fixes.

Given no NixOS module is available in nixpkgs marking the package
with `knownVulnerabilities` should have a limited impact.
@LeSuisse LeSuisse added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.05 labels Dec 3, 2024
@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 3, 2024
@Aleksanaa
Aleksanaa merged commit 3e7643a into NixOS:master Dec 4, 2024
@nixpkgs-ci

nixpkgs-ci Bot commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-361567-to-release-24.05 origin/release-24.05
cd .worktree/backport-361567-to-release-24.05
git switch --create backport-361567-to-release-24.05
git cherry-pick -x 384f6f592b99f7ed384da7282d6aa6166eae075b

@nixpkgs-ci

nixpkgs-ci Bot commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-24.11:

@LeSuisse
LeSuisse deleted the authentik-flag-known-vulnerabilities branch December 4, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants