bottom: add gpu recognition, new apple sdk, refactor#360568
Merged
Merged
Conversation
github-actions
Bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
ofborg
Bot
added
11.by: package-maintainer
Member
|
uncenter
approved these changes
Dec 2, 2024
uncenter
added
the
12.approvals: 1
wegank
added
the
2.status: merge conflict
gepbird
force-pushed
the
bottom-gpu-fix
branch
from
9fadc8a to
405bafb
Compare
Contributor
Author
|
Fixed "merge conflict" by #322537 Since I had a nixfmt commit, I didn't need to resolve a usual merge conflict, when rebasing git automatically dropped my now empty nixfmt commit. |
gepbird
force-pushed
the
bottom-gpu-fix
branch
from
405bafb to
fbacb0a
Compare
gepbird
removed
the
2.status: merge conflict
gepbird
force-pushed
the
bottom-gpu-fix
branch
from
fbacb0a to
c895be2
Compare
github-actions
Bot
removed
10.rebuild-darwin: 1
gepbird
force-pushed
the
bottom-gpu-fix
branch
from
c895be2 to
665b5ab
Compare
gepbird
force-pushed
the
bottom-gpu-fix
branch
from
665b5ab to
cf269ec
Compare
Contributor
Author
|
Member
|
uncenter
approved these changes
Dec 11, 2024
ofborg
Bot
added
10.rebuild-darwin: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ClementTsang/bottom#1629
Tracking: #354146, can't test it as I don't have a darwin machine, but in another commit (9a78e67) I saw this exact change so most likely it works.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.