nexusmods-app: fix passthru tests

[MattSturgeon]

While working on #354015 and #360174, I noticed that the passthru tests are not actually passing. I don't think this is a new issue, rather I think this has just gone unnoticed until now.

I've resolved the fontconfig related issues in one commit, but I've had to disable the tests in another. I believe the issue is that the CLI also launches the GUI (Nexus-Mods/NexusMods.App#2179), which I assume will not work in the stdenv sandbox?

EDIT: The other issues were resolved by ensuring XDG_STATE_HOME and XDG_DATA_HOME exist and are writable.

Build using

$ nix-build -A nexusmods-app.passthru.tests --check

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[corngood]

I've noticed that these tests pass intermittently, at least on my machine.

Edit: to be clear, I mean without this change. If this makes them reliable then that's awesome.

[MattSturgeon]

If we just want an empty and/or default fontconfig file, is there a better alternative to using makeFontsConfig?

[l0b0]

Build using

$ nix-build -A pkgs.nexusmods-app.passthru.tests

That finishes in less than a second on my machine, with no feedback and exit code 0. Adding --check does not change the outcome.

nix-build -A nexusmods-app --check fails with this interesting message:

error: derivation '/nix/store/5xzldg25sballz8119xvrjsfrfjr9xdj-nexusmods-app-0.6.3.drv' may not be deterministic: output '/nix/store/7ccpwslwpnig1gfz99mbsq946bzb9vi9-nexusmods-app-0.6.3' differs

[MattSturgeon]

Build using

$ nix-build -A pkgs.nexusmods-app.passthru.tests

That finishes in less than a second on my machine, with no feedback and exit code 0. Adding --check does not change the outcome.

Sorry, I should've been more clear. That's how to run the tests, however the second commit in this PR completely disables all the tests. See https://github.com/NixOS/nixpkgs/pull/354018/files#r1863938537

I intended that command for testing without this PR and/or testing the first commit of this PR.

---

I've noticed that these tests pass intermittently, at least on my machine.

Interesting... I was unable to get the tests to build at all, and assumed it was due to Nexus-Mods/NexusMods.App#2179 (hence disabling them entirely in the second commit)

[corngood]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354018

[MattSturgeon]

I've had to disable the tests in another. I believe the issue is that the CLI also launches the GUI (Nexus-Mods/NexusMods.App#2179), which I assume will not work in the stdenv sandbox?

This proved incorrect.

Ensuring XDG_STATE_HOME and XDG_DATA_HOME exist and are writable is enough for all passthru tests to pass.

I guess it was failing while attempting to write its initial state and/or logs.

This PR now fixes the passthru tests without needing to disable any of them.

[corngood]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354018

---

x86_64-linux

[nixpkgs-ci]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] nexusmods-app: fix passthru tests #363950