Skip to content

clightning: 24.05 -> 24.08 #340442

Merged
prusnak merged 1 commit into
NixOS:masterfrom
ocfox:clightning
Sep 8, 2024
Merged

clightning: 24.05 -> 24.08 #340442
prusnak merged 1 commit into
NixOS:masterfrom
ocfox:clightning

Conversation

@ocfox

@ocfox ocfox commented Sep 8, 2024

Copy link
Copy Markdown
Member

Description of changes

This will fix build https://hydra.nixos.org/build/270933657

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

fix build broken by add distutils
@ocfox ocfox requested review from jb55 and prusnak September 8, 2024 05:02
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 8, 2024
@prusnak

prusnak commented Sep 8, 2024

Copy link
Copy Markdown
Member

@ocfox can you please drop the formatting change from the PR? I don't like it

@ocfox

ocfox commented Sep 8, 2024

Copy link
Copy Markdown
Member Author

No problem, I just use nixfmt-rfc-style.

@prusnak prusnak merged commit 0cbd052 into NixOS:master Sep 8, 2024
@ocfox ocfox deleted the clightning branch September 8, 2024 09:17
@kirillrdy

Copy link
Copy Markdown
Member

@prusnak nixfmt-rfc-style is widely accepted, and even enforce for new changes #326407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants