nuget-to-nix: comply with RFC 0166 when generating .nix files#339842
Closed
Scrumplex wants to merge 1 commit into
Closed
nuget-to-nix: comply with RFC 0166 when generating .nix files#339842Scrumplex wants to merge 1 commit into
Scrumplex wants to merge 1 commit into
Conversation
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Contributor
|
I'd say this is a duplicate of #325053. There are various problems with doing it this way. I think the consensus was just to ignore nixfmt on these files for now. |
Member
Author
|
I see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This changed nuget-to-nix to generate .nix files that comply with RFC 0166.
Brought up in #339630
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.