authentik: move inlined python modules to the standard python modules - #338629
Merged
Conversation
github-actions
Bot
added
the
6.topic: python
ofborg
Bot
added
10.rebuild-darwin: 1-10
jvanbruegge
suggested changes
Aug 31, 2024
Contributor
|
I opened a PR to update authentik to the newest version and I integrated your changes there to save you the hassle of fixing merge conflicts: #345940 |
Member
Author
|
I will reopen this for now and merge this later this week if there are no issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
We have python-modules so that we can share the python dependencies between packages, so we really should not inline python modules into other packages, when possible.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.