nexusmods-app: use finalAttrs

[MattSturgeon]

Description of changes

• nexusmods-app: use finalAttrs for recursive fixpoint
• nexusmods-app: use buildInputs for dependencies

Follow up to #331355, make use of the finalAttrs support added to buildDotnetModule in #331398. Hopefully anything recursive in the package is now done correctly.

I was unsure how to handle the relationship between executables and meta.mainProgram, so I decided to define both explicitly for now. Perhaps buildDotnetModule should consider setting mainProgram automatically to head executables?

I also replaced the manual wrapper PATH creation with buildInputs for the desktop-file-utils dependency. AFAICT everything is still working.

Related issues:

• Documentation: guide for using let in vs rec vs finalAttrs #315337
• Superfluous use of finalAttrs.{pname,version} introducing overriding traps #310373

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

cc @corngood @l0b0

---

Add a 👍 reaction to pull requests you find important.

[MattSturgeon]

Result of nixpkgs-review pr 336221 run on x86_64-linux 1

2 packages built:

• nexusmods-app
• nexusmods-app-unfree

[eclairevoyant]

Can you explain the reasoning for this change? desktop-file-utils only contains binaries, so putting it in buildInputs seems like a no-op to me.

[MattSturgeon]

I guess I thought buildInputs would populate the PATH. Thanks for clarifying! I'll revert the change.

With writeShellApplication I'd use runtimeInputs, looking at the implementation, it's doing essentially what we did before:

nixpkgs/pkgs/build-support/trivial-builders/default.nix

Line 277 in d26fd47

export PATH="${lib.makeBinPath runtimeInputs}:$PATH"

Is this the best/only way to populate the PATH? Is there any idiom of making the bin-path overridable via an extra attr passed to mkDerivation (i.e. a runtimeInputs)?

[SuperSandro2000]

Otherwise LGTM, good improvement

[corngood]

@MattSturgeon Everything seems to be addressed, right? Okay if I merge?

[MattSturgeon]

Everything seems to be addressed, right? Okay if I merge?

@corngood Yes, everything should be good, thanks! 👍