systemd-boot: Revert boot counting again#334526
Merged
emilazy merged 2 commits intoAug 14, 2024
Merged
Conversation
github-actions
Bot
added
6.topic: nixos
emilazy
approved these changes
Aug 14, 2024
emilazy
left a comment
emilazy
left a comment
Member
There was a problem hiding this comment.
Looks reasonable at a skim. I hope we can get this back ASAP once the dust has settled and the channels are moving again. I will check tests on aarch64-linux.
ofborg
Bot
added
10.rebuild-darwin: 1-10
Member
|
I don't have an intermediate use case for boot counting, so I probably won't spend time on getting it to work. This was only happening on aarch64, right? |
Member
|
No, eval broke for the entire channel. |
Contributor
Author
|
And the specialisation bug was platform independent |
13 tasks
iFreilicht
added a commit
to iFreilicht/.dotfiles
that referenced
this pull request
Aug 26, 2024
Now I don't need to carry around an old version of nixpkgs just for nextcloud 27 anymore. I mainly wanted to do this update because of boot counting, but that has since been reverted: NixOS/nixpkgs#334526
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Unfortunately, with the specialisation-related regression caused by boot counting, and fixes like #334473 being generally hasty and unsatisfactory, the most effective way to unblock the unstable channel is to simply revert boot counting.
This was made a little tricky, as there were three, other, PRs that were merged for systemd-boot this week, which interfered with the revert. I believe I've preserved those PRs correctly, and all systemd-boot tests seem to pass, including the
specialisationone on aarch64 (it's the only one testing thedevicetreechange).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.