Skip to content

Recyclarr: build from source#334009

Merged
SuperSandro2000 merged 4 commits into
NixOS:masterfrom
josephst:feat/recyclarr-from-source
Aug 22, 2024
Merged

Recyclarr: build from source#334009
SuperSandro2000 merged 4 commits into
NixOS:masterfrom
josephst:feat/recyclarr-from-source

Conversation

@josephst

@josephst josephst commented Aug 11, 2024

Copy link
Copy Markdown
Member

Description of changes

This PR brings recyclarr to the latest version and switches from using a pre-built binary to building from source using buildDotnetModule. The package is also moved to by-name.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg Bot requested a review from aldoborrero August 11, 2024 23:42
@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 11, 2024
@josephst josephst marked this pull request as ready for review August 12, 2024 01:19
@josephst josephst force-pushed the feat/recyclarr-from-source branch from 009b655 to 18ebd72 Compare August 12, 2024 01:23
@nixos-discourse

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4393

@josephst josephst changed the title Recycler: build from source Recyclarr: build from source Aug 12, 2024
Comment thread pkgs/by-name/re/recyclarr/package.nix Outdated
Comment thread pkgs/by-name/re/recyclarr/package.nix Outdated
Comment thread pkgs/by-name/re/recyclarr/package.nix Outdated
Comment thread pkgs/by-name/re/recyclarr/package.nix Outdated
Comment thread pkgs/by-name/re/recyclarr/package.nix Outdated
Comment thread pkgs/by-name/re/recyclarr/package.nix Outdated
Comment thread pkgs/by-name/re/recyclarr/package.nix
Comment thread pkgs/by-name/re/recyclarr/package.nix Outdated
Comment thread pkgs/by-name/re/recyclarr/package.nix Outdated
@josephst josephst force-pushed the feat/recyclarr-from-source branch from 7871aac to aaba7b8 Compare August 12, 2024 03:18
@josephst

Copy link
Copy Markdown
Member Author

Just force-pushed a new version - using finalAttrs.version and confirmed the update script still works.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 14, 2024
@josephst josephst requested a review from eclairevoyant August 16, 2024 02:32
Comment thread pkgs/tools/video/recyclarr/default.nix Outdated
@SuperSandro2000 SuperSandro2000 merged commit 1201edc into NixOS:master Aug 22, 2024
@josephst josephst deleted the feat/recyclarr-from-source branch April 20, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants