catboost: use llvm 14 for cuda#333562
Conversation
e19db93 to
53914c7
Compare
There was a problem hiding this comment.
Yeah ideally we'd accommodate in cudaPackages (the same logic that handles gcc version ranges) but admittedly that might take a non-trivial refactoring and it's ok to postpone it. CC @NixOS/cuda-maintainers
53914c7 to
290a347
Compare
290a347 to
ab66c4d
Compare
|
See #370663 (comment). |
|
Is catboost/catboost#2540 still a problem? I tried bumping CUDA to 12 but ran into errors like this: |
I didn't check but I'd not expect this to change: they use a higher level tool ( |
|
I've brought up the CUDA 11 thing with upstream - catboost/catboost#2755. I don't consider it a blocker for this PR. I'm mainly worried about getting things off LLVM 12. |
This does not look like an error caused by unsupported CUDA architecture related to catboost/catboost#2540. This is something else. In conda catboost is built successfully with CUDA 12.0 (and CUDA 12.1 and 12.2 should work as well) using patching CMakeLists by removing unsupported architectures like this: Static vs shared CUDA libraries could also be an issue (but it does not depend on CUDA version): https://github.com/conda-forge/catboost-feedstock/blob/234a16cbeeeb12bb02bb3eff7282a1cbce9c979f/recipe/build.sh#L64-L66 |
|
Ok, I'm going to definitely just consider the CUDA bump a non-issue for this PR. I don't have the time or knowledge to figure out this problem. My concern has only been getting things off LLVM 12 so we can drop it. |
Description of changes
Upgrade to a newer LLVM version for CUDA (related #305146), format so CI doesn't complain.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.