vatprism: init at 0.3.5#329794
Merged
Merged
Conversation
github-actions
Bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12.first-time contribution
eclairevoyant
previously requested changes
Jul 25, 2024
eclairevoyant
left a comment
eclairevoyant
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Some feeback below:
Contributor
Author
|
Everything should be fixed now. I figured I'd add a desktop entry while I was at it. |
ofborg
Bot
added
8.has: package (new)
JohnRTitor
reviewed
Jul 26, 2024
JohnRTitor
reviewed
Jul 26, 2024
JohnRTitor
reviewed
Jul 26, 2024
ofborg
Bot
removed
the
10.rebuild-linux: 1
Member
|
Result of 2 packages built:
|
JohnRTitor
approved these changes
Jul 27, 2024
JohnRTitor
left a comment
JohnRTitor
left a comment
Member
There was a problem hiding this comment.
Built and ran successfully.
JohnRTitor
reviewed
Jul 27, 2024
Member
|
Result of 1 package built:
|
Member
|
Result of 2 packages built:
|
JohnRTitor
approved these changes
Jul 28, 2024
JohnRTitor
left a comment
JohnRTitor
left a comment
Member
There was a problem hiding this comment.
Builds and runs on both x64 and aarch64 linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.