nixos/keymapper: init module#328921
Conversation
github-actions
Bot
added
6.topic: nixos
ofborg
Bot
added
10.rebuild-darwin: 0
felbinger
left a comment
felbinger
left a comment
There was a problem hiding this comment.
You have quite a complex logic to create the configuration.
What do you think of a module test to ensure that the configuration is created correctly?
There was a problem hiding this comment.
use inherit (lib) mkOption types ...; instead, see #208242
There was a problem hiding this comment.
replace null with "keymapper", to generate documentation correctly
felbinger
left a comment
felbinger
left a comment
There was a problem hiding this comment.
I have not checked the logic for creating the configuration. Maybe that can be improved.
|
@ofborg test keymapper |
h7x4
added
8.has: module (new)
spitulax
force-pushed
the
keymapper-module
branch
from
2966734 to
db4a58d
Compare
|
A github workflow has been adjusted (#326407), could you trigger the ci again by pushing a new commit? |
|
The new Github workflow should have been run though. I checked the Github action on commit |
|
@spitulax Just so you know, you need to cleanup the commit history (by git rebase), before this can be reviewed and merged. |
Added option to enable `keymapperd` service used to provide communication between the user-level program `keymapper` which needs permission to grab keyboard and inject keys.
spitulax
force-pushed
the
keymapper-module
branch
from
cd69bad to
39f0395
Compare
wegank
added
the
2.status: merge conflict
nixpkgs-ci
Bot
added
2.status: stale
| if hasPrefix "no" n && v != null then | ||
| ''${removePrefix "no" n}!="${v}"'' | ||
| else if v != null then | ||
| ''${n}="${v}"'' |
There was a problem hiding this comment.
@spitulax Auto-quoting here prevents usage of regexes in config, as in:
[title = /Visual Studio Code|Code OSS/i]
5 participants
Description of changes
Added NixOS module services.keymapper to enable
keymapperdservice used to provide communication between the user-level programkeymapperwhich needs permission to grab keyboard and inject keys.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.