emacspeak: 58.0 -> 59.0#291953
Merged
Merged
Conversation
ofborg
Bot
added
8.has: package (new)
Atemu
reviewed
Feb 28, 2024
Also, keep a green alias in order to not break things.
- finalAttrs design pattern - set strictDeps - getExe emacs - get rid of nested with - set meta.changelog - set meta.mainProgram
Atemu
reviewed
Feb 28, 2024
Atemu
approved these changes
Feb 28, 2024
Also, updates broken version according to the changelog. Co-authored-by: R. RyanTM <ryantm-bot@ryantm.com>
jian-lin
reviewed
Oct 10, 2024
| @@ -1,34 +1,37 @@ | |||
| { lib | |||
| , stdenv | |||
| , emacs | |||
Contributor
There was a problem hiding this comment.
Directly pulling in emacs has some issues:
- the unneeded
emacsis in the closure ofemacs-nox.pkgs.emacspeak - native compilation results of
emacs-nox.pkgs.emacspeak, if generated, will not be used byemacs-nox
BTW, the directory structure of $out is probably wrong because it is quite different from other packages in emacsPackages.
jian-lin
reviewed
Oct 10, 2024
| inherit (self) callPackage; | ||
| in | ||
| { | ||
| inherit (pkgs) emacspeak; |
Contributor
There was a problem hiding this comment.
Applying this patch can fix issues mentioned here. However, whether this package should be moved to "by-name" needs discussion.
- inherit (pkgs) emacspeak;
+ emacspeak = pkgs.emacspeak.override { emacs = self.emacs; };
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #291869
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.