transmission_4: init at 4.0.3#241146
Merged
Merged
Conversation
ofborg
Bot
added
10.rebuild-darwin: 1-10
Member
Author
|
Getting this to build on x86_64-darwin will not be easy. transmission 4 needs macOS >= 10.14.6. The current build failure is due to some constants missing from the CommonCrypto headers. |
jtojnar
reviewed
Jul 3, 2023
SuperSandro2000
approved these changes
Jul 3, 2023
ambroisie
approved these changes
Jul 3, 2023
Member
Author
|
I've been using this PR instead of #215316 in my nixos-config without issues ever since creating it. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1017 |
Member
|
Thanks! |
12 tasks
Member
|
@chvp may I ask why nixosTest wasn't carried over from transmission 3 ? seems to be still passing for me |
Member
Author
|
Forgetting to do so, probably. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/transmission/transmission/releases/tag/4.0.0
https://github.com/transmission/transmission/releases/tag/4.0.1
https://github.com/transmission/transmission/releases/tag/4.0.2
https://github.com/transmission/transmission/releases/tag/4.0.3
Previous discussion (on why this isn't just an update) in #215316.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)