Skip to content

tree-sitter/update: move grammar definitions into toml#199547

Closed
Profpatsch wants to merge 5 commits into
NixOS:masterfrom
Profpatsch:tree-sitter-move-grammars-to-toml
Closed

tree-sitter/update: move grammar definitions into toml#199547
Profpatsch wants to merge 5 commits into
NixOS:masterfrom
Profpatsch:tree-sitter-move-grammars-to-toml

Conversation

@Profpatsch

@Profpatsch Profpatsch commented Nov 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Member
Description of changes

Small follow-up to #190083 which separates the grammar definitions for the implementation code by moving them into grammars.toml. builtins.fromTOML has been in nix since 2.1, the nixpkgs minimum nix version is 2.3.

Also add more documentation on how to update grammars/add new grammars.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Profpatsch Profpatsch requested a review from jonringer as a code owner November 4, 2022 18:28
@github-actions github-actions Bot added the 6.topic: vim Advanced text editor label Nov 4, 2022
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 4, 2022
@Profpatsch Profpatsch mentioned this pull request Nov 4, 2022
Closed
13 tasks
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale Bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@kimburgess kimburgess mentioned this pull request May 4, 2025
Closed
@uncenter

uncenter commented Dec 17, 2025

Copy link
Copy Markdown
Member

As with #200028, now that grammar sources and updating has been reworked in #408414 I believe this can be closed?

@uncenter uncenter closed this Dec 17, 2025
@uncenter uncenter added the 6.topic: tree-sitter Tree-sitter is a parser generator tool and an incremental parsing library. label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: tree-sitter Tree-sitter is a parser generator tool and an incremental parsing library. 6.topic: vim Advanced text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Profpatsch @uncenter @wegank