nixos/home-assistant: use override before overridePythonAttrs

[dotlambda]

Motivation for this change

f9bd8b1#commitcomment-49202157
@sweber83 Can you check whether this fixes it?

I think you can't use override after using overridePythonAttrs. I had the same problem in #118391 (comment).
cc @FRidh

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[sweber83]

@dotlambda
This fixes the problem.

What I still find a bit problematic, is the case, where the user wants to override the package herself and not only passes the package to the hass module but also to environment.systemPackages for example.
In this case the tests are executed and the user can't prevent it by using overridePythonAttrs themselves because of the problem of the invocation order.
So the user has to know, that they have to use overrideAttrs with doInstallCheck = false instead of overridePythonAttrs with doCheck = false.

[FRidh]

So the user has to know, that they have to use overrideAttrs with doInstallCheck = false instead of overridePythonAttrs with doCheck = false.

Known issue. See NixOS/rfcs#67 (comment) so overrides are sent to the correct function. doCheck = doInstallCheck is separate and a legacy issue.

[sweber83]

@FRidh
Thanks, wasn't known to me :)

[dotlambda]

We could add a warning to the option's description.

[Mic92]

Works for me.

[sweber83]

Works as intended and the warning about overridePythonAttrs should be helpful.

[mweinelt]

So, this used to work before, now it breaks. Same when I use overridePythonAttrs.

    package = (pkgs.home-assistant.override {
      extraPackages = ps: with ps; [ psycopg2 ];
    }).overrideAttrs (oldAttrs: {
      patches = [
        ./patches/brightsky.patch
        ./patches/prometheus-sensor.patch
        ./patches/prometheus-event-listener-callback.patch
      ];
      doCheck = false;
    });

I now get

error: attribute 'overridePythonAttrs' missing, at /etc/nixos/nixpkgs/nixos/modules/services/misc/home-assistant.nix:58:13

How can I apply patches after this change?

[dotlambda]

@mweinelt Sorry! I guess it makes sense to go back to your original solution using overrideAttrs.

[mweinelt]

@sweber83 What was your initial setup that failed? Did you override the packages some way yourself?

[sweber83]

@mweinelt
Commit f9bd8b1 broke home assistant, when no overrides where used.
When I applied overridePythonAttrs it was also broken.
As I understand it, the problem is, that one can't call override on the result of the overridePythonAttrs invocation.
The problem with your override then seems to be similar, only that it's overridePythonAttrs which is not available, after calling overrideAttrs.
Going back to the original solution really seems best.