top-level/packages-config.nix: Correctly index package subsets delimited by dots#113680
Closed
adisbladis wants to merge 1 commit into
Closed
top-level/packages-config.nix: Correctly index package subsets delimited by dots#113680adisbladis wants to merge 1 commit into
adisbladis wants to merge 1 commit into
Conversation
4ab4190 to
4060a6d
Compare
Member
Search have their OOT version of this file to generate the search index; that's where I copied it from actually ;) |
Atemu
requested changes
Feb 19, 2021
Atemu
left a comment
Member
There was a problem hiding this comment.
Aborts with infinite recursion for me.
Also needs a bit of formatting cleanup and/or refactoring I think ;)
10 tasks
Member
Author
|
Closing this one as I think #113713 is clearly better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes the issue discovered by @Atemu in #110348 (comment) where dot delimited subsets were not taken into account.
Note: I haven't tested how this interacts with search at all, I've just assumed it's probably fine. This needs more testing to see what the implications are, hence I've marked it as draft.
cc @garbas
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)