Make lowdown optional#9710
Merged
Merged
Conversation
Member
Member
Author
|
I don't think readline support has regressed since de59973? Like, it's still possible to build Nix on Linux with env = {
EDITLINE_LIBS = "${readline}/lib/libhistory${stdenv.hostPlatform.extensions.sharedLibrary} ${readline}/lib/libreadline${stdenv.hostPlatform.extensions.sharedLibrary}";
EDITLINE_CFLAGS = "-DREADLINE";
};So I didn't try to make editline optional... |
Member
|
OK fair enough :) ignore readline/editline for now is fine. But the "yes vs auto" I still had in my You should also do a |
Co-authored-by: John Ericson <John.Ericson@Obsidian.Systems>
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR makes the lowdown library optional. Specifically, when
--disable-markdownis passed,renderMarkdownToTerminalbecomes trivial, i.e. Markdown is not rendered:Context
lowdown currently has no MinGW support (kristapsdz/lowdown#130). While this PR is inspired by the commit with the same name in #4953, the latter hasn't been updated for two years. I think it's good to have a PR with an atomic commit to drive the changes forward, one by one.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.