Backport 7447 to 2.13 maintenance#8763
Merged
edolstra merged 3 commits intoAug 7, 2023
Merged
Conversation
Allows checking directory entry type of a single file/directory. This was added to optimize the use of `builtins.readDir` on some filesystems and operating systems which cannot detect this information using POSIX's `readdir`. Previously `builtins.readDir` would eagerly use system calls to lookup these filetypes using other interfaces; this change makes these operations lazy in the attribute values for each file with application of `builtins.readFileType`. (cherry picked from commit 153ee46)
(cherry picked from commit 37c533e)
* Fixup release notes
roberth
requested review from
edolstra,
fricklerhandwerk and
thufschmitt
as code owners
Member
|
I guess it is OK to skip some releases to backport since this is not a behavioral change? |
Member
Author
|
It is not a behavior change except for Also it can be argued to fix the buggy |
Member
|
oh my bad I think i was looking at the wrong diff. If this is alreaydd in 2.14 (or 2.15 cause 2.14 is kinda of informally deprecated) no problem. |
Member
|
Btw I implemented a very hacky workaround for it here: https://github.com/NixOS/nixpkgs/pull/222981/files#diff-c7ec15b333bb1ce2cb8065610ad1952b59fbb0fa244cf272c12b7e020c2fa146L37-R86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solve the issue raised in
Context
Closes #8392 which I couldn't force push
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.