add *.md files to makefile install#8484
Closed
gador wants to merge 1 commit into
Closed
Conversation
Member
|
I'm a bit meh on that one as these |
Member
|
Yeah the bug here is definitely including an |
8 tasks
zhaofengli
added a commit
to zhaofengli/attic
that referenced
this pull request
Jun 13, 2023
Let's work around it downstream while we wait for a release. Fixes #56.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After the merge of #8084 the files in
libstorenow include the documentation*.mdfiles. These files do not get copied bymake, which in turn causes errors when linking those header files. (See e.g. zhaofengli/attic#56)This came apparent after the update of nix stable on
nixpkgsin NixOS/nixpkgs#233439 which causes a regression for me.Context
This trivial change now includes the
*.mdfiles which fixes the issue. (Tested on current nixpkgs master). In my case (tested withattic, see issue linked above), I run into a different issue later on, but I guess it is unrelated. The follow up issue is(EDIT:
Please ignore the version identifier of
nix. I overwrote it to test my fork which included the fix)Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.