fix: set status to 'active' on user registration - #1346
Open
Kirtan-pc wants to merge 1 commit into
Open
Conversation
Both registerUser and walletRegister created users without explicitly setting status, so they inherited the schema default of 'pending'. loginUser, walletLogin, and the protect middleware all reject non-active accounts, making newly registered users unable to log in. Set status: 'active' in both registration paths so self-registered accounts are immediately usable. Fixes Nitya-003#1228
|
@Kirtan-pc is attempting to deploy a commit to the Nitya Gosain's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Issue #1228: newly registered users cannot log in because
User.statusdefaults to"pending"and nothing in the codebase ever activates self-registered accounts. BothloginUserandwalletLoginhard-reject non-active accounts, and theprotectmiddleware blocks all authenticated routes for non-active users, leaving self-registered accounts permanently stuck.Changes
registerUser(backend/controllers/authController.js:170-176): Addedstatus: "active"to theUser.createcall so email/password registrations produce immediately usable accounts.walletRegister(backend/controllers/authController.js:625-631): Addedstatus: "active"to theUser.createcall so wallet-based registrations produce immediately usable accounts.##Fixes #1228
Copilot Review Feedback
Other suggestions were evaluated but intentionally left unchanged because they are pre-existing issues outside the scope of Issue #1228:
User.jsschema from"pending"to"active""pending"default is intentional for admin-created accounts that require approval; only self-registration paths need immediate activation