Skip to content

perimeter only logic was swapped #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NiklasMelton merged 2 commits into from
Jul 24, 2025
Merged

perimeter only logic was swapped #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40003c5
perimiter only logic was swapped
NiklasMelton Jul 24, 2025
d50e1af
update tests
NiklasMelton Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyalphashape/AlphaShape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,9 @@ def add_points(self, new_pts: np.ndarray, perimeter_only: bool = False) -> None:
"""

if perimeter_only:
pts = np.vstack([self.points, new_pts])
else:
pts = np.vstack([self.perimeter_points, new_pts])
else:
pts = np.vstack([self.points, new_pts])
self.__init__( # type: ignore[misc]
pts,
alpha=self.alpha,
Expand Down
21 changes: 18 additions & 3 deletions unit_tests/test_AlphaShape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,29 @@ def test_distance_to_surface_various_cases():


def test_add_points_grows_shape():
points = np.array([[0, 0], [1, 0], [0.5, 1]])
shape = AlphaShape(points, alpha=3.0)
points = np.array([[0, 0], [1, 0], [0, 1]])
shape = AlphaShape(points, alpha=0.0)
n_perim_before = len(shape.perimeter_points)
shape.add_points(np.array([[0.5, 1.5]]), perimeter_only=False)
shape.add_points(np.array([[1, 1]]), perimeter_only=False)
n_perim_after = len(shape.perimeter_points)
assert n_perim_after > n_perim_before


def test_add_points_perimeter_only():
points = np.array([[0, 0], [1, 0], [0.1, 1]])
shape = AlphaShape(points, alpha=0.0)
shape.add_points(np.array([[0, 2]]), perimeter_only=True)
n_perim_after = len(shape.perimeter_points)
assert n_perim_after == 3

def test_add_points_all_points():
points = np.array([[0, 0], [1, 0], [0.1, 1]])
shape = AlphaShape(points, alpha=10.0, connectivity="relaxed")
shape.add_points(np.array([[0, 2]]), perimeter_only=False)
n_perim_after = len(shape.perimeter_points)
assert n_perim_after == 4


def test_get_boundary_facets_returns_facets():
points = np.random.rand(10, 3)
shape = AlphaShape(points, alpha=1.0)
Expand Down