[repo-assist] feat: add ToUnixMilliseconds, ToUnixSeconds, FromUnixMilliseconds, FromUnixSeconds#22
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
…omUnixSeconds Add four Unix epoch convenience methods to complement the existing ToUnixNanoseconds(): - ToUnixMilliseconds() — whole milliseconds since Unix epoch (sub-ms truncated) - ToUnixSeconds() — whole seconds since Unix epoch (sub-s truncated) - FromUnixMilliseconds(long) — factory from milliseconds since epoch - FromUnixSeconds(long) — factory from seconds since epoch These are especially useful when interoperating with REST APIs, databases, and other systems that exchange timestamps in seconds or milliseconds. Six new tests cover round-trips, truncation behaviour, and negative-input guards. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This pull request was created by Repo Assist, an automated AI assistant.
Summary
Add four Unix epoch convenience methods to
DateTimeNano, complementing the existingToUnixNanoseconds()/NanosecondsSinceEpoch:ToUnixMilliseconds()longToUnixSeconds()longFromUnixMilliseconds(long)DateTimeNanoFromUnixSeconds(long)DateTimeNanoWhy
Many external systems (REST APIs, databases, financial feeds) exchange timestamps in seconds or milliseconds rather than nanoseconds:
Before:
After:
This makes the API symmetric:
ToUnixNanoseconds()now has siblings at millisecond and second granularity, matching the conventions ofDateTimeOffset.ToUnixTimeMilliseconds()/FromUnixTimeMilliseconds()in the BCL.Implementation notes
DateTime.ToUnixTimeSeconds()andToUnixTimeMilliseconds()).FromUnixMilliseconds/FromUnixSecondsthrowArgumentOutOfRangeExceptionfor negative inputs (pre-epoch timestamps are not representable byDateTimeNano).Test Status
✅ 46 tests pass on net8.0, net9.0, and net10.0 (40 original + 6 new tests covering round-trips, truncation, and negative-input guards). Build succeeded with 0 errors.