[repo-assist] test: add coverage for implicit operators, parts constructor, overflow guards, and edge cases#20
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
…w guards, and edge cases - Add tests for implicit DateTime ↔ DateTimeNano conversion operators - Add tests for the parts constructor (year, month, day, ...) directly - Add test for local DateTime → UTC conversion in constructor - Add test for Date property returning midnight - Add test for AddNanoseconds positive overflow guard - Add tests for AddMonths/AddYears with negative values - Add tests for Equals(object?) override (null, wrong type, equal) - Add tests for TryParse/Parse with ISO 8601 T separator - Add test for Subtract OverflowException on >292-year gap Total: 55 tests (was 40) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This pull request was created by Repo Assist, an automated AI assistant.
Summary
Adds 15 new tests covering previously untested paths in
DateTimeNano, bringing the total to 55 tests (was 40).What's covered by the new tests
Constructor_Parts_ShouldCreateCorrectValue,Constructor_Parts_DefaultsToMidnightConstructor_LocalDateTime_ShouldConvertToUtcDatepropertyDate_Property_ShouldReturnMidnightAddNanosecondsoverflowAddNanoseconds_ShouldThrow_WhenPositiveOverflowAddMonths/AddYearsnegativeAddMonths_Negative_ShouldDecreaseCorrectly,AddYears_Negative_ShouldDecreaseCorrectlyEquals(object?)overridenull, wrong typeDateTimeNano → DateTime,DateTime → DateTimeNanoTryParse_WithTSeparator_ShouldSucceed,Parse_WithTSeparator_ShouldSucceedSubtractoverflowSubtract_ShouldThrow_WhenDifferenceExceedsLongMaxValueWhy
These paths existed and worked correctly but had no automated verification. The additions:
DateTime ↔ DateTimeNano) behave as documented.T-separator strings are accepted byTryParse/Parse.No production code was changed.
Test Status
✅ All 55 tests pass on
net8.0. Build succeeded for net8.0, net9.0, and net10.0 with 0 warnings.