[repo-assist] perf: replace compiled Regex with [GeneratedRegex] source-generated regex#17
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
…egex Use the [GeneratedRegex] attribute (available since .NET 7) to replace the runtime-compiled static Regex field in DateTimeNano.TryParse with a source-generated partial method. Benefits: - Regex is compiled at build time, not at first access, eliminating startup overhead when the static field is first touched. - Generated code is typically faster than RegexOptions.Compiled at runtime for .NET 8+. - Enables full AOT/NativeAOT compatibility (compiled regexes are not AOT-friendly; source-generated ones are). - Compile-time validation of the regex pattern. The struct is now declared partial (no public API change). All 40 existing tests pass unchanged on net8.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This pull request was created by Repo Assist, an automated AI assistant.
Summary
Replace the runtime-compiled
static readonly Regexfield inTryParsewith a source-generated partial method using the[GeneratedRegex]attribute.What changed
DateTimeNanois now declaredpartial struct, and theDateTimeRegexstatic field is replaced with:TryParsecallsDateTimeRegex()instead of accessing the field.Why
RegexOptions.Compiled)[GeneratedRegex])[GeneratedRegex]was introduced in .NET 7 and is the recommended approach for .NET 8/9/10+ projects. The library already targetsnet8.0;net9.0;net10.0, so there is no framework constraint.Trade-offs
partial, but this is a non-breaking change — no public API surface changes.Test Status
✅ All 40 tests pass on
net8.0. Build succeeded for net8.0, net9.0, and net10.0 with 0 warnings.