[repo-assist] feat: add + and - arithmetic operators for nanosecond offsets#15
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
Add two new operators: - operator+(DateTimeNano, long): shift a timestamp forward by N nanoseconds - operator-(DateTimeNano, long): shift a timestamp back by N nanoseconds These complement the existing operator-(DateTimeNano, DateTimeNano) that returns the nanosecond difference, and are thin wrappers around the already- validated AddNanoseconds method (overflow/underflow protection is inherited). Add four unit tests covering positive offset, negative offset, sign inversion via the + operator, and underflow guard. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This pull request was created by Repo Assist, an automated AI assistant.
Summary
Add two new arithmetic operators to
DateTimeNano:operator +(DateTimeNano, long)— shift a timestamp forward by N nanosecondsoperator -(DateTimeNano, long)— shift a timestamp back by N nanosecondsThese are thin wrappers around the existing, validated
AddNanosecondsmethod, so overflow/underflow protection is fully inherited.Rationale
The type already exposes
operator -(DateTimeNano, DateTimeNano)that returns the nanosecond difference. The natural complement is to also allowtimestamp + offsetandtimestamp - offsetarithmetic with a plainlongnanosecond count. This matches the ergonomics ofSystem.DateTime(DateTime + TimeSpan,DateTime - TimeSpan).Before:
After:
Trade-offs
operator -(DateTimeNano, long)andoperator -(DateTimeNano, DateTimeNano)coexist because their right-hand types are different (longvsDateTimeNano). No ambiguity.Test Status
✅ 44 tests pass on
net8.0(40 original + 4 new tests covering the new operators).