Add Linux support and switch to official AmxModX github release URL for auto compiler download.#8
Conversation
Co-authored-by: Copilot <copilot@github.com>
|
Since you are downloading a file that contains binary executables. I have added file integrity check using SHA256 algorithm. Downloading from official source and verifying integrity will help your extension getting approved into Visual Studio marketplace. |
|
Great job on this! Moving the compiler download to the official releases and adding the SHA256 integrity checks is a significant improvement. I've verified the hashes, and they match the files exactly. However, I found a couple of issues in the extractZip function (within CP.exec) that will cause the process to fail in certain environments:
Suggested Fix Once these small adjustments are made, this PR will be ready to merge! |
…nsion bug for bash command
|
Fixed. Thanks for the tips! |
This pull request updates the way the AMX Mod X compiler is downloaded and extracted from official release page for both Linux and Windows users.
Tested and it work for both Linux and Windows.
Note: Linux users have to install 32bit support for their distro because the amxxpc compiler is 32bit.