Skip to content

math: flt reads an f32-backed input directly (skip the double hop) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NiceAndPeter merged 1 commit into from
Jun 22, 2026
Merged

math: flt reads an f32-backed input directly (skip the double hop) #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions include/bound/cmath.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,7 +1215,7 @@ namespace bnd::math
#if defined(BND_MATH_NO_FP)
return sqrt_signed_impl<Out>(x);
#elif defined(BND_MATH_FLOAT)
float v = static_cast<float>(static_cast<double>(x));
float v = flt::to_float(x);
if (v < 0.0f)
return slim::expected<Out, errc>{slim::unexpected(errc::domain_error)};
return slim::expected<Out, errc>{flt::store<Out>(flt::detail::d_sqrt(v))};
Expand Down Expand Up @@ -1292,7 +1292,7 @@ namespace bnd::math
#if defined(BND_MATH_NO_FP)
return pow_base_impl<Base, Out>(x);
#elif defined(BND_MATH_FLOAT)
return flt::store<Out>(flt::detail::d_pow(static_cast<float>(Base), static_cast<float>(static_cast<double>(x))));
return flt::store<Out>(flt::detail::d_pow(static_cast<float>(Base), flt::to_float(x)));
#else
return dbl::store<Out>(dbl::detail::d_pow(static_cast<double>(Base), static_cast<double>(x)));
#endif
Expand Down Expand Up @@ -1385,7 +1385,7 @@ namespace bnd::math
#if defined(BND_MATH_NO_FP)
return tan_impl<Out>(angle);
#elif defined(BND_MATH_FLOAT)
float x = static_cast<float>(static_cast<double>(angle));
float x = flt::to_float(angle);
float c = flt::detail::d_cos(x);
if (c == 0.0f)
return slim::expected<Out, errc>{slim::unexpected(errc::division_by_zero)};
Expand Down Expand Up @@ -1508,7 +1508,7 @@ namespace bnd::math
constexpr int W = detail::working_bits<AMP>();
out = detail::sin_slot<M, W>(bnd::detail::raw_imax(angle));
#elif defined(BND_MATH_FLOAT)
out = flt::detail::d_sin(static_cast<float>(static_cast<double>(angle)) * (flt::detail::kPi / 180.0f));
out = flt::detail::d_sin(flt::to_float(angle) * (flt::detail::kPi / 180.0f));
#else
out = dbl::detail::d_sin(static_cast<double>(angle) * (dbl::detail::kPi / 180.0));
#endif
Expand All @@ -1524,7 +1524,7 @@ namespace bnd::math
constexpr int W = detail::working_bits<AMP>();
out = detail::sin_slot<M, W>(bnd::detail::raw_imax(angle) + M / 4);
#elif defined(BND_MATH_FLOAT)
out = flt::detail::d_cos(static_cast<float>(static_cast<double>(angle)) * (flt::detail::kPi / 180.0f));
out = flt::detail::d_cos(flt::to_float(angle) * (flt::detail::kPi / 180.0f));
#else
out = dbl::detail::d_cos(static_cast<double>(angle) * (dbl::detail::kPi / 180.0));
#endif
Expand All @@ -1546,7 +1546,7 @@ namespace bnd::math
out = (detail::sin_slot<M, W>(i) / c).value(); // sin / cos
return true;
#elif defined(BND_MATH_FLOAT)
float rad = static_cast<float>(static_cast<double>(angle)) * (flt::detail::kPi / 180.0f);
float rad = flt::to_float(angle) * (flt::detail::kPi / 180.0f);
float c = flt::detail::d_cos(rad);
if (c == 0.0f) return false; // pole
out = flt::detail::d_sin(rad) / c;
Expand Down Expand Up @@ -2025,10 +2025,10 @@ namespace bnd::math
#if defined(BND_MATH_NO_FP)
return pow_impl<Out>(base, exp);
#elif defined(BND_MATH_FLOAT)
float b = static_cast<float>(static_cast<double>(base));
float b = flt::to_float(base);
if (b <= 0.0f)
return slim::expected<Out, errc>{slim::unexpected(errc::domain_error)};
float r = flt::detail::d_pow(b, static_cast<float>(static_cast<double>(exp)));
float r = flt::detail::d_pow(b, flt::to_float(exp));
if constexpr (!has_flag(BoundPolicy<Out>, clamp)) // clamp Out: saturate below
if (r < static_cast<float>(static_cast<double>(Lower<Out>)) || r > static_cast<float>(static_cast<double>(Upper<Out>)))
return slim::expected<Out, errc>{slim::unexpected(errc::overflow)};
Expand Down Expand Up @@ -2327,7 +2327,7 @@ namespace bnd::math
{
static_assert(bnd::math::detail::require_snap<In>());
using Out = bnd::math::detail::sqrt_signed_auto_t<In>;
float v = static_cast<float>(static_cast<double>(x));
float v = flt::to_float(x);
if (v < 0.0f)
return slim::expected<Out, errc>{slim::unexpected(errc::domain_error)};
return slim::expected<Out, errc>{store<Out>(detail::d_sqrt(v))};
Expand Down Expand Up @@ -2362,7 +2362,7 @@ namespace bnd::math
{
static_assert(bnd::math::detail::require_snap<In>());
using Out = bnd::math::detail::pow_base_auto_t<Base, In>;
return store<Out>(detail::d_pow(static_cast<float>(Base), static_cast<float>(static_cast<double>(x))));
return store<Out>(detail::d_pow(static_cast<float>(Base), flt::to_float(x)));
}

template <boundable In>
Expand All @@ -2378,7 +2378,7 @@ namespace bnd::math
{
static_assert(bnd::math::detail::require_snap<In>());
using Out = bnd::math::detail::tan_auto_t<In>;
float x = static_cast<float>(static_cast<double>(angle));
float x = flt::to_float(angle);
float c = detail::d_cos(x);
if (c == 0.0f)
return slim::expected<Out, errc>{slim::unexpected(errc::division_by_zero)};
Expand Down Expand Up @@ -2442,10 +2442,10 @@ namespace bnd::math
{
static_assert(bnd::math::detail::require_snap<InB>() && bnd::math::detail::require_snap<InE>());
using Out = bnd::math::detail::pow_auto_t<InB, InE>;
float b = static_cast<float>(static_cast<double>(base));
float b = flt::to_float(base);
if (b <= 0.0f)
return slim::expected<Out, errc>{slim::unexpected(errc::domain_error)};
float r = detail::d_pow(b, static_cast<float>(static_cast<double>(exp)));
float r = detail::d_pow(b, flt::to_float(exp));
if constexpr (!has_flag(BoundPolicy<Out>, clamp)) // clamp Out: saturate below
if (r < static_cast<float>(static_cast<double>(Lower<Out>)) || r > static_cast<float>(static_cast<double>(Upper<Out>)))
return slim::expected<Out, errc>{slim::unexpected(errc::overflow)};
Expand Down
46 changes: 29 additions & 17 deletions include/bound/cmath_float.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,42 +234,54 @@ namespace bnd::math::flt
else { Out o{}; o = bnd::detail::rational{static_cast<double>(f)}; return o; }
}

// Read an input bound as `float`. An f32-backed operand IS a binary32 raw, so
// read it directly — no double hop (keeps the whole flt+f32 path in hardware
// float on a single-precision FPU). Any other storage decodes via double then
// narrows; float→double→float round-trips to the same float, so this is a pure
// optimization with no value change.
template <typename In>
[[nodiscard]] BND_DBL_FN float to_float(In x)
{
if constexpr (bnd::detail::f32_raw<In>) return x.raw();
else return static_cast<float>(static_cast<double>(x));
}

template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out sin_core(In x) { return store<Out>(detail::d_sin(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out sin_core(In x) { return store<Out>(detail::d_sin(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out cos_core(In x) { return store<Out>(detail::d_cos(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out cos_core(In x) { return store<Out>(detail::d_cos(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out exp_core(In x) { return store<Out>(detail::d_exp(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out exp_core(In x) { return store<Out>(detail::d_exp(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out sqrt_core(In x) { return store<Out>(detail::d_sqrt(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out sqrt_core(In x) { return store<Out>(detail::d_sqrt(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out log_core(In x) { return store<Out>(detail::d_log(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out log_core(In x) { return store<Out>(detail::d_log(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out exp2_core(In x) { return store<Out>(detail::d_exp2(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out exp2_core(In x) { return store<Out>(detail::d_exp2(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out log2_core(In x) { return store<Out>(detail::d_log2(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out log2_core(In x) { return store<Out>(detail::d_log2(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out log10_core(In x){ return store<Out>(detail::d_log10(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out log10_core(In x){ return store<Out>(detail::d_log10(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out cbrt_core(In x) { return store<Out>(detail::d_cbrt(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out cbrt_core(In x) { return store<Out>(detail::d_cbrt(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out sinh_core(In x) { return store<Out>(detail::d_sinh(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out sinh_core(In x) { return store<Out>(detail::d_sinh(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out cosh_core(In x) { return store<Out>(detail::d_cosh(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out cosh_core(In x) { return store<Out>(detail::d_cosh(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out tanh_core(In x) { return store<Out>(detail::d_tanh(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out tanh_core(In x) { return store<Out>(detail::d_tanh(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out atan_core(In x) { return store<Out>(detail::d_atan(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out atan_core(In x) { return store<Out>(detail::d_atan(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out asin_core(In x) { return store<Out>(detail::d_asin(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out asin_core(In x) { return store<Out>(detail::d_asin(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out acos_core(In x) { return store<Out>(detail::d_acos(static_cast<float>(static_cast<double>(x)))); }
[[nodiscard]] BND_DBL_FN Out acos_core(In x) { return store<Out>(detail::d_acos(to_float(x))); }
template <typename Out, typename In>
[[nodiscard]] BND_DBL_FN Out atan2_core(In y, In x)
{ return store<Out>(detail::d_atan2(static_cast<float>(static_cast<double>(y)), static_cast<float>(static_cast<double>(x)))); }
{ return store<Out>(detail::d_atan2(to_float(y), to_float(x))); }
template <typename Out, typename InX, typename InY>
[[nodiscard]] BND_DBL_FN Out hypot_core(InX x, InY y)
{ return store<Out>(detail::d_hypot(static_cast<float>(static_cast<double>(x)), static_cast<float>(static_cast<double>(y)))); }
{ return store<Out>(detail::d_hypot(to_float(x), to_float(y))); }
} // namespace bnd::math::flt

#endif // !BND_MATH_NO_FP
Expand Down
Loading
Loading