Add optional filename field to image, audio, and video messages#114
Open
spantaleev wants to merge 1 commit into
Open
Add optional filename field to image, audio, and video messages#114spantaleev wants to merge 1 commit into
filename field to image, audio, and video messages#114spantaleev wants to merge 1 commit into
Conversation
Matrix media-caption semantics use the `filename` field to distinguish between a caption in `body` and the original upload filename. This was already supported for `m.file`, but missing from `m.image`, `m.audio` and `m.video`. This patch adds `filename` to all three message types, matching the existing `m.file` implementation: - parsed when present - serialized only when non-empty All related field comments were updatd to reflect the current Matrix media-caption semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matrix media-caption semantics use the
filenamefield to distinguish between a caption inbodyand the original upload filename.This was already supported for
m.file, but missing fromm.image,m.audioandm.video.This patch adds
filenameto all three message types, matching the existingm.fileimplementation:All related field comments were updatd to reflect the current Matrix media-caption semantics.