Add notification cleanup service and scheduler and Masking FCM Token

[subsub97]

This pull request introduces a robust cleanup mechanism for stale PENDING notifications, ensuring that any notifications scheduled before a certain threshold date are properly marked as EXPIRED. It also improves FCM token logging security and adds comprehensive tests for the new cleanup logic and token masking. The main changes are organized below:

Notification Cleanup Mechanism:

• Added a scheduled component (NotificationCleanupScheduler) that runs daily to expire PENDING notifications older than 7 days, logging a warning if any are found, which helps monitor missed dispatches.
• Introduced NotificationCleanupService to handle the bulk update of stale PENDING notifications to EXPIRED and increment a metric for monitoring.
• Extended NotificationLogRepository with a new bulk update method markExpiredBefore to efficiently mark old PENDING notifications as EXPIRED using a JPQL query. [1] [2]

Testing and Verification:

• Added integration tests (NotificationLogRepositoryCleanupTest) to verify the correctness of the bulk update JPQL query against a real database, ensuring only intended records are updated.
• Added unit tests for the cleanup service (NotificationCleanupServiceTest) and scheduler (NotificationCleanupSchedulerTest) to ensure correct metric counting and delegation logic. [1] [2]

FCM Token Logging Security:

• Improved FCM token logging by masking all but the first 8 characters of the token in logs, reducing risk of sensitive data exposure. Added unit tests for the masking logic. [1] [2] [3]

[github-actions]

Test Results

109 tests   109 ✅  1s ⏱️
 18 suites    0 💤
 18 files      0 ❌

Results for commit f713a53.

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

This PR adds an operational safety net for notifications by expiring stale PENDING notification logs on a daily schedule, and improves security of FCM token logging by masking tokens in log messages. It also introduces unit/integration tests to validate the cleanup behavior and token masking.

Changes:

• Add NotificationCleanupService + NotificationCleanupScheduler to bulk-expire old PENDING notifications and record a Micrometer metric.
• Extend NotificationLogRepository with a JPQL bulk update (markExpiredBefore) and verify it with a real DB @DataJpaTest.
• Mask FCM tokens in logs (prefix-only) and add tests for the masking behavior.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/main/kotlin/com/moa/service/notification/NotificationCleanupService.kt	Implements bulk expiration of stale PENDING notifications and increments a cleanup metric by actual updated rows.
src/main/kotlin/com/moa/service/notification/NotificationCleanupScheduler.kt	Runs daily at 01:00 (Asia/Seoul) with ShedLock to invoke cleanup and log when unexpected stale records exist.
src/main/kotlin/com/moa/repository/NotificationLogRepository.kt	Adds markExpiredBefore(threshold) JPQL bulk update to set PENDING → EXPIRED for old scheduled dates.
src/main/kotlin/com/moa/service/FcmService.kt	Masks FCM tokens in exception logs and adds a reusable maskToken helper.
src/test/kotlin/com/moa/service/notification/NotificationCleanupServiceTest.kt	Unit tests ensure metrics increment only by actual updated row count (and not when 0 rows updated).
src/test/kotlin/com/moa/service/notification/NotificationCleanupSchedulerTest.kt	Unit tests verify correct threshold calculation/delegation and non-failing behavior when updates occur.
src/test/kotlin/com/moa/repository/NotificationLogRepositoryCleanupTest.kt	Integration tests validate the JPQL bulk update against a real DB and edge conditions (strict threshold, non-PENDING excluded).
src/test/kotlin/com/moa/service/FcmServiceTokenMaskTest.kt	Unit tests for token masking behavior (long/short/empty token cases).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.