Skip to content

ci(deploy-tests): update rust v10 version, and reorder the sequence#3711

Merged
rodrodros merged 2 commits into
mainfrom
ci/update-rust-tests
Jun 8, 2026
Merged

ci(deploy-tests): update rust v10 version, and reorder the sequence#3711
rodrodros merged 2 commits into
mainfrom
ci/update-rust-tests

Conversation

@brbrr
Copy link
Copy Markdown
Contributor

@brbrr brbrr commented Jun 8, 2026

No description provided.

@brbrr brbrr self-assigned this Jun 8, 2026
Copilot AI review requested due to automatic review settings June 8, 2026 10:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the “Deploy and Test” GitHub Actions workflow to adjust the ordering of downstream test jobs and bump the Starknet Rust RPC v0.10 test reference.

Changes:

  • Added/moved the starknet-rust-rpcv10 job earlier in the workflow and updated its ref to 0.19.1.
  • Reordered job dependencies so starknet-js-rpcv08 waits on starknet-rs-rpcv09.
  • Updated starknet-rs-rpcv09 dependency chain (currently contains an invalid needs reference).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/deploy-and-test.yaml
Comment thread .github/workflows/deploy-and-test.yaml Outdated
@brbrr brbrr force-pushed the ci/update-rust-tests branch from 26c7c99 to fe52947 Compare June 8, 2026 10:38
@NethermindEth NethermindEth deleted a comment from github-actions Bot Jun 8, 2026
@NethermindEth NethermindEth deleted a comment from github-actions Bot Jun 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2026

Claude finished @brbrr's task in 50s —— View job


Claude review — ci(deploy-tests): update rust v10 version, and reorder the sequence

  • Read the PR diff (git diff origin/main...HEAD)
  • Verify the job dependency graph at current HEAD
  • Cross-check earlier bot review comments against current state

Summary

The change reorders the serial starknet-rs/starknet-rust chain and bumps the v0.10 Rust test ref 0.19.0 → 0.19.1. Looks correct as currently committed. All needs references resolve to existing jobs.

The serial chain at current HEAD (lines 114–136):

deploy → starknet-rust-rpcv10 → starknet-rs-rpcv09 → starknet-rs-rpcv08
Job needs Resolves?
starknet-rust-rpcv10 (114) [deploy]
starknet-rs-rpcv09 (122) [deploy, starknet-rust-rpcv10]
starknet-rs-rpcv08 (130) [deploy, starknet-rs-rpcv09]

Re: earlier bot comments (now stale)

Both prior review comments appear to have been written against an earlier commit and no longer apply to current HEAD:

  • Copilot — "needs references a non-existent job starknet-rs-rpcv10" (line 124): Resolved. Line 123 reads needs: [deploy, starknet-rust-rpcv10] — note rust, not rs, which is the real job at line 114. No invalid reference remains.
  • "starknet-rs-rpcv08 detaches from the serial chain": Resolved. Line 131 has needs: [deploy, starknet-rs-rpcv09], so v8 still runs last in the serial chain rather than concurrently.

Notes (nit)

  • The reorder reverses the execution order from v8 → v9 → v10 to v10 → v9 → v8. This is consistent with the PR title and reads as intentional (newest version first). No action needed — just confirming the chain is still fully serialized against the single deployed node.

Verdict: No blocking or important issues. The dependency graph is valid and the chain remains serial. 👍

Note: I can't push edits to files under .github/workflows/ (GitHub App workflow-scope restriction), but none are needed here.
ci/update-rust-tests

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2026

Claude finished @brbrr's task in 33s —— View job


Claude review — ci(deploy-tests): update rust v10 version, and reorder the sequence

  • Read the PR diff (git diff origin/main...HEAD)
  • Verify the job dependency graph at current HEAD
  • Cross-check earlier bot review comments against current state

Summary

This PR reorders the serial starknet-rs/starknet-rust test chain (newest-version-first) and bumps the v0.10 Rust test ref 0.19.0 → 0.19.1. It's clean — all needs references resolve to defined jobs and the chain remains fully serial against the single deployed node.

Serial chain at current HEAD (lines 114–136):

deploy → starknet-rust-rpcv10 → starknet-rs-rpcv09 → starknet-rs-rpcv08
Job needs Resolves?
starknet-rust-rpcv10 (114) [deploy]
starknet-rs-rpcv09 (122) [deploy, starknet-rust-rpcv10]
starknet-rs-rpcv08 (130) [deploy, starknet-rs-rpcv09]

Earlier bot comments — now stale

Both prior review comments were written against an earlier commit and no longer apply:

  • Copilot — "needs references non-existent job starknet-rs-rpcv10": Resolved. Line 123 reads needs: [deploy, starknet-rust-rpcv10] (rust, not rs), matching the real job at line 114.
  • "starknet-rs-rpcv08 detaches from the serial chain": Resolved. Line 131 has needs: [deploy, starknet-rs-rpcv09], so v8 still runs last in the serial chain.

Verdict: No blocking, important, or nit-level issues. The dependency graph is valid and the suites remain serialized. 👍
ci/update-rust-tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.55%. Comparing base (ea473bf) to head (bf664b4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3711      +/-   ##
==========================================
+ Coverage   76.52%   76.55%   +0.03%     
==========================================
  Files         405      405              
  Lines       36942    36942              
==========================================
+ Hits        28269    28281      +12     
+ Misses       6680     6673       -7     
+ Partials     1993     1988       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brbrr brbrr temporarily deployed to Development June 8, 2026 11:39 — with GitHub Actions Inactive
@rodrodros rodrodros merged commit 9de7658 into main Jun 8, 2026
37 of 40 checks passed
@rodrodros rodrodros deleted the ci/update-rust-tests branch June 8, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants