ci(deploy-tests): update rust v10 version, and reorder the sequence#3711
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the “Deploy and Test” GitHub Actions workflow to adjust the ordering of downstream test jobs and bump the Starknet Rust RPC v0.10 test reference.
Changes:
- Added/moved the
starknet-rust-rpcv10job earlier in the workflow and updated itsrefto0.19.1. - Reordered job dependencies so
starknet-js-rpcv08waits onstarknet-rs-rpcv09. - Updated
starknet-rs-rpcv09dependency chain (currently contains an invalidneedsreference).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
26c7c99 to
fe52947
Compare
|
Claude finished @brbrr's task in 50s —— View job Claude review —
|
| Job | needs |
Resolves? |
|---|---|---|
starknet-rust-rpcv10 (114) |
[deploy] |
✅ |
starknet-rs-rpcv09 (122) |
[deploy, starknet-rust-rpcv10] |
✅ |
starknet-rs-rpcv08 (130) |
[deploy, starknet-rs-rpcv09] |
✅ |
Re: earlier bot comments (now stale)
Both prior review comments appear to have been written against an earlier commit and no longer apply to current HEAD:
- Copilot — "
needsreferences a non-existent jobstarknet-rs-rpcv10" (line 124): Resolved. Line 123 readsneeds: [deploy, starknet-rust-rpcv10]— noterust, notrs, which is the real job at line 114. No invalid reference remains. - "
starknet-rs-rpcv08detaches from the serial chain": Resolved. Line 131 hasneeds: [deploy, starknet-rs-rpcv09], so v8 still runs last in the serial chain rather than concurrently.
Notes (nit)
- The reorder reverses the execution order from
v8 → v9 → v10tov10 → v9 → v8. This is consistent with the PR title and reads as intentional (newest version first). No action needed — just confirming the chain is still fully serialized against the single deployed node.
Verdict: No blocking or important issues. The dependency graph is valid and the chain remains serial. 👍
Note: I can't push edits to files under
.github/workflows/(GitHub App workflow-scope restriction), but none are needed here.
•ci/update-rust-tests
|
Claude finished @brbrr's task in 33s —— View job Claude review —
|
| Job | needs |
Resolves? |
|---|---|---|
starknet-rust-rpcv10 (114) |
[deploy] |
✅ |
starknet-rs-rpcv09 (122) |
[deploy, starknet-rust-rpcv10] |
✅ |
starknet-rs-rpcv08 (130) |
[deploy, starknet-rs-rpcv09] |
✅ |
Earlier bot comments — now stale
Both prior review comments were written against an earlier commit and no longer apply:
- Copilot — "
needsreferences non-existent jobstarknet-rs-rpcv10": Resolved. Line 123 readsneeds: [deploy, starknet-rust-rpcv10](rust, notrs), matching the real job at line 114. - "
starknet-rs-rpcv08detaches from the serial chain": Resolved. Line 131 hasneeds: [deploy, starknet-rs-rpcv09], so v8 still runs last in the serial chain.
Verdict: No blocking, important, or nit-level issues. The dependency graph is valid and the suites remain serialized. 👍
• ci/update-rust-tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3711 +/- ##
==========================================
+ Coverage 76.52% 76.55% +0.03%
==========================================
Files 405 405
Lines 36942 36942
==========================================
+ Hits 28269 28281 +12
+ Misses 6680 6673 -7
+ Partials 1993 1988 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.