Skip to content

Run GitHub test actions on contributor forks. #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theengineear merged 1 commit into from
Sep 23, 2025
Merged

Run GitHub test actions on contributor forks. #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/check-branch.yaml
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions .github/workflows/check-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Run tests on pushes to main branch.
name: Check Main
on:
push:
branches: [main]

@theengineear theengineear Sep 23, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue to run tests on main (e.g., after a PR is merged) as a sanity check.

jobs:
test:
uses: ./.github/workflows/test.yaml
7 changes: 7 additions & 0 deletions .github/workflows/check-pull-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Run tests on pull requests, including from forks.
name: Check Pull Request
on:
pull_request

@theengineear theengineear Sep 23, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default GitHub will target the opened, synchronize, or reopened types (so we don’t need to write that all out). See pull_request docs.

jobs:
test:
uses: ./.github/workflows/test.yaml
2 changes: 1 addition & 1 deletion ts/x-template.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion x-template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ class TemplateEngine {
// }
// }
static #removeWithin(node) {
node.replaceChildren()
node.replaceChildren();

@theengineear theengineear Sep 23, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was what caused the lint check to fail. Now that we run all this for PRs — we would expect to catch this sort of thing in review!

}

// TODO: Future state — we may choose to iterate differently as an
Expand Down