Expose the current step's status to SEL for conditional branching - #231
Merged
Conversation
ykitaev
approved these changes
Jul 31, 2026
rdeepak2002
approved these changes
Jul 31, 2026
rdeepak2002
left a comment
Collaborator
There was a problem hiding this comment.
Lgtm! TIL that evaluateNextConditionParams is called only after the step is already in a terminal state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew build --write-locksto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
A step transition condition is evaluated in the context of the step it is attached to, so it can already read that step's own params, but it had no way to read that step's status. The status was only reachable for a different step, through the two-arg
params.getFromStep('<step>', 'MAESTRO_STEP_STATUS'), which needs the referenced step to be already finished and therefore cannot be the step the condition hangs off.This adds the status to the single-arg current-step accessor, so a transition condition can branch on how its own step ended:
StepInstanceAttributescarries the status from the step's runtime state, andfromStep(String)returns it under the existingMAESTRO_STEP_STATUSkey, alongsideMAESTRO_STEP_ERROR_RETRIESwhich is already exposed there. The SEL language guide documents the single-arg overload, which was previously undocumented.