Support configurable default parameters via application config - #230
Merged
Conversation
rdeepak2002
approved these changes
Jul 21, 2026
rdeepak2002
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR, this is a good step toward making Maestro more configurable
[out of scope of this pr] Along those lines, I’ve also noticed other areas of the codebase that are hard to extend, such as the StepType enum. For example, if someone wanted to introduce a new step type, they’d have to modify that enum directly, as there’s currently no straightforward way to "register" a new step type.
derek-miller
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew build --write-locksto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Default parameters currently ship only as packaged classpath resources under
maestro-engine/src/main/resources/defaultparams/. This PR lets them be overridden or extended from Spring application config, so a deployment can adjust defaults without editing the bundled files or forking them.A new
maestro.default-paramsconfig carries a YAML blob per category (workflow,step,dry-run, and per step type). Each blob is merged onto the bundled defaults by parameter name, using the same YAML mapper already used to read the resource files. Behavior is unchanged when no config is present.For example, the same default parameter often needs a different value per environment. Setting a
clusterdefault tostagingin the staging cluster, and to the production cluster name in production, lets each deployment supply its own value in config rather than by patching the packageddefaultparams/*.yaml.clusteris only an illustration; any default parameter can be overridden or added the same way.