Re-type workflow summary once at flow start ingress to avoid per-poll deserialization - #225
Merged
Merged
Conversation
derek-miller
approved these changes
Jul 2, 2026
rdeepak2002
approved these changes
Jul 2, 2026
rdeepak2002
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for optimizing this!
Collaborator
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew build --write-locksto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
When a flow starts on a node that does not own its group, the workflow summary is sent over REST and deserialized into an untyped
Map, soflow.getInput()holds aLinkedHashMapinstead of aWorkflowSummary. Every step poll then re-runs a full JacksonconvertValueover the whole summary and discards the result, which shows up as significant CPU and allocation/GC overhead on the step execute path, growing with workflow size.This change re-materializes the summary into a typed
WorkflowSummaryonce at the flow-start REST ingress, so downstream reads take the cheap cast path instead of converting on every poll.