Allow a step to be fatally failed via a RetryArtifact in its output data - #224
Merged
Conversation
derek-miller
approved these changes
Jun 25, 2026
rdeepak2002
reviewed
Jun 29, 2026
| import com.netflix.maestro.MaestroBaseTest; | ||
| import org.junit.Test; | ||
|
|
||
| public class RetryArtifactTest extends MaestroBaseTest { |
Collaborator
There was a problem hiding this comment.
I noticed that other tests in this module, such as WhileArtifactTest.java and TitusArtifactTest.java, include a testRoundTripSerde that verifies the general serde contract.
Would it make sense to add a similar testRoundTripSerde here for consistency and to cover the round-trip behavior as well?
rdeepak2002
approved these changes
Jun 29, 2026
rdeepak2002
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for creating this pr! Left a minor comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew build --write-locksto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
being retried.
later.